update

2026-04-08 19:08:40 +02:00
parent 40644eb362
commit 0f7742f10d
25 changed files with 750 additions and 77 deletions
--- a/.paul/PROJECT.md
+++ b/.paul/PROJECT.md
@@ -89,6 +89,8 @@ Sprzedawca moĹĽe obsĹ‚ugiwaÄ‡ zamĂłwienia ze wszystkich kanaĹ‚Ăłw
 - [x] Dedykowane pull mapowanie statusow Allegro przy imporcie zamowien — Phase 83
 - [x] Automatyzacja: zdarzenie `order.imported` przy pobraniu zamowienia (Allegro + shopPRO) — Phase 84
 - [x] Filtrowanie zamowien po grupie statusow (klikalna nazwa grupy na panelu) — Phase 85
+- [x] Naprawa tworzenia przesylek COD Apaczka — dodanie numeru konta bankowego do payloadu API — Phase 86
+- [x] Usuwanie przesylek z zakladki Przesylki w szczegolach zamowienia (z potwierdzeniem) — Phase 87
 - [ ] Eliminacja zduplikowanego kodu: SslCertificateResolver, ToggleableRepositoryTrait, RedirectPathResolver, ReceiptService — Phase 68

 ### Active (In Progress)
--- a/.paul/ROADMAP.md
+++ b/.paul/ROADMAP.md
@@ -46,6 +46,8 @@ Wersja mobilna aplikacji, modul po module. Cel: pelna uzywalnosc orderPRO na tel
 | 83 | Allegro Pull Status Mapping | 1/1 | Complete |
 | 84 | Order Imported Automation Event | 1/1 | Complete |
 | 85 | Status Group Filter | 1/1 | Complete |
+| 86 | Apaczka COD Bank Account | 1/1 | Complete |
+| 87 | Shipment Delete | 1/1 | Complete |
 | TBD | Mobile Orders List | - | Not started |
 | TBD | Mobile Order Details | - | Not started |
 | TBD | Mobile Settings | - | Not started |
--- a/.paul/STATE.md
+++ b/.paul/STATE.md
@@ -2,22 +2,22 @@

 ## Project Reference

-See: .paul/PROJECT.md (updated 2026-04-07)
+See: .paul/PROJECT.md (updated 2026-04-08)

 **Core value:** Sprzedawca moze obslugiwac zamowienia ze wszystkich kanalow sprzedazy i nadawac przesylki bez przelaczania sie miedzy platformami.
-**Current focus:** Milestone v3.0 - Phase 85 complete, ready for next PLAN
+**Current focus:** Milestone v3.0 - Phase 87 complete, ready for next PLAN

 ## Current Position

 Milestone: v3.0 Mobile Responsive - In progress
-Phase: 85 (Status Group Filter) — Complete
-Plan: 85-01 unified
+Phase: 87 (Shipment Delete) — Complete
+Plan: 87-01 unified
 Status: Loop complete, ready for next PLAN
-Last activity: 2026-04-07 — Unified .paul/phases/85-status-group-filter/85-01-PLAN.md
+Last activity: 2026-04-08 — Unified .paul/phases/87-shipment-delete/87-01-PLAN.md

 Progress:
- Milestone: [#########.] ~92%
- Phase 85: [##########] 100%
+- Milestone: [#########.] ~93%
+- Phase 87: [##########] 100%

 ## Loop Position

@@ -29,10 +29,10 @@ PLAN ──▶ APPLY ──▶ UNIFY

 ## Session Continuity

-Last session: 2026-04-07
-Stopped at: Plan 85-01 unified
+Last session: 2026-04-08
+Stopped at: Plan 87-01 unified
 Next action: Run /paul:plan for the next prioritized phase
-Resume file: .paul/phases/85-status-group-filter/85-01-SUMMARY.md
+Resume file: .paul/phases/87-shipment-delete/87-01-SUMMARY.md

 ## Git State

--- a/.paul/changelog/2026-04-08.md
+++ b/.paul/changelog/2026-04-08.md
@@ -0,0 +1,22 @@
+# 2026-04-08
+
+## Co zrobiono
+
+- [Phase 86, Plan 01] Naprawa bledu API Apaczka przy tworzeniu przesylki COD
+- Dodano pole `bankaccount` (numer konta bankowego) do payloadu COD w ApaczkaShipmentService
+- Walidacja: brak numeru konta w ustawieniach firmy rzuca czytelny blad
+- Czyszczenie numeru konta z prefixu PL i spacji do 26 cyfr
+
+- [Phase 87, Plan 01] Usuwanie przesylek z zakladki Przesylki w szczegolach zamowienia
+- Metoda delete() w ShipmentPackageRepository i ShipmentController
+- Endpoint POST /orders/{id}/shipment/{packageId}/delete z CSRF i owner check
+- Cleanup pliku etykiety z dysku, activity log shipment_deleted
+- Przycisk "Usun" z potwierdzeniem OrderProAlerts.confirm w tabeli przesylek
+
+## Zmienione pliki
+
+- `src/Modules/Shipments/ApaczkaShipmentService.php`
+- `src/Modules/Shipments/ShipmentPackageRepository.php`
+- `src/Modules/Shipments/ShipmentController.php`
+- `routes/web.php`
+- `resources/views/orders/show.php`
--- a/.paul/docs/API.md
+++ b/.paul/docs/API.md
@@ -0,0 +1,3 @@
+# API
+
+> Endpointy, kontrakty request/response, autentykacja.
--- a/.paul/docs/ARCHITECTURE.md
+++ b/.paul/docs/ARCHITECTURE.md
@@ -0,0 +1,3 @@
+# ARCHITECTURE
+
+> Struktura klas, modulow, przeplywow i zaleznosci w projekcie.
--- a/.paul/docs/DB_SCHEMA.md
+++ b/.paul/docs/DB_SCHEMA.md
@@ -0,0 +1,3 @@
+# DB_SCHEMA
+
+> Schemat bazy danych — tabele, kolumny, FK, indeksy.
--- a/.paul/docs/DECISIONS.md
+++ b/.paul/docs/DECISIONS.md
@@ -0,0 +1,3 @@
+# DECISIONS
+
+> Kluczowe decyzje techniczne i ich uzasadnienia.
--- a/.paul/docs/STACK.md
+++ b/.paul/docs/STACK.md
@@ -0,0 +1,3 @@
+# STACK
+
+> Stack technologiczny, wersje, zaleznosci, srodowisko.
--- a/.paul/docs/TECH_CHANGELOG.md
+++ b/.paul/docs/TECH_CHANGELOG.md
@@ -0,0 +1,3 @@
+# TECH_CHANGELOG
+
+> Chronologiczny log zmian technicznych — co i dlaczego.
--- a/.paul/docs/TODO.md
+++ b/.paul/docs/TODO.md
@@ -0,0 +1,233 @@
+# TODO
+
+> Luzny parking pomyslow, rzeczy do sprawdzenia.
+
+15. [x] W tym miejscu odwróć kolejność: najpierw źródło potem ID, <div class="orders-ref__meta"><span>f6079660-1af8-11f1-a7c9-231cf6ef29d1</span><span>allegro</span></div>
+17. [x] Na liście zamówien jak jest źródło i id zamówienia to zamiast shopPRO musi pisać która integracja konkretnie. Oraz dodajemy napis ID: ...D
+
+## SonarQube — post plany 02-02 i 02-03 (skan 2026-03-13)
+30. [] [Sonar 2026-03-13] Brak nowych issues — AllegroStatusSyncService i ShopproOrderSyncStateRepository czyste. Pre-existing issues w ShopproOrdersSyncService (god class) i Application.php niezmienione przez nasze modyfikacje.
+
+## SonarQube — post plan 01-01 (skan 2026-03-12)
+28. [] [Sonar 2026-03-12] php:S1142 — AllegroTokenManager::resolveToken() ma 4 returny (powyżej limitu 3) (1x nowe)
+29. [] [Sonar 2026-03-12] php:S112 — AllegroTokenManager rzuca generic RuntimeException zamiast dedykowanej klasy wyjątku (3x nowe)
+
+## SonarQube — code quality (327 issues, skan 2026-03-12)
+18. [] php:S112 (95x) — zastąpić generic `new \Exception` konkretnymi klasami wyjątków
+19. [] php:S1142 (57x) — zredukować liczbę `return` w metodach (early return › wydzielić metody)
+20. [] php:S1192 (40x) — wyciągnąć powtarzające się string literals do stałych
+21. [] php:S3776 (31x) — obniżyć złożoność kognitywną metod (wydzielić logikę do pomocniczych metod)
+22. [] Web:S6827 (15x) — dodać brakujące atrybuty `alt` na tagach `<img>`
+23. [] Web:S6819 (12x) — poprawić dostępność HTML (accessibility)
+24. [] php:S1172 (11x) — usunąć nieużywane parametry funkcji
+25. [] php:S3358 (11x) — rozwinąć zagnieżdżone operatory ternarne
+26. [] php:S1448 (6x) — podzielić klasy z za dużą liczbą metod
+27. [] php:S138 (4x) — skrócić zbyt długie metody
+
+
+31. [x] blokować wystawienie kolejnego paragonu do tego samego zamówienia, nie całkowicie, ale powinno ono wymagać wyrażnego potwierdzenia w formie alertu
+
+## SonarQube — post plan 19-01 (skan 2026-03-22)
+32. [] [Sonar 2026-03-22] php:S4833 — show.php:696 Replace `require` with namespace import `use` keyword (1x)
+33. [] [Sonar 2026-03-22] php:S2003 — show.php:696 Replace `require` with `require_once` (1x)
+34. [] [Sonar 2026-03-22] php:S1448 — OrdersController ma 22 metody (limit 20) — rozdzielić (1x)
+35. [] [Sonar 2026-03-22] php:S1142 — OrdersController::bulkPrint() ma 5 returnów (limit 3) (1x)
+36. [] [Sonar 2026-03-22] php:S1068 — AllegroIntegrationController nieużywane pole $statusDiscoveryService (1x, pre-existing)
+
+37. [x] Nie działa zapisywanie numer REGON
+38. [x] Customowe przyciski paczek
+39. [x] Zmiana głównego koloru przycisków z niebieskiego na inny (bo się z nagłówkami myli)
+40. [x] Usunąć przycisk "Drukuj etykiety" z widoku https://orderpro.projectpro.pl/orders/list razem z mechanizmem, który to obsługuje
+41. [x] Jaki jest sens tylu logów z importu allegro np w tym zamówieniu https://orderpro.projectpro.pl/orders/29, skąd taka ilość, co jest pobierane i sprawdzane?
+42. [x] Nowy zdarzenie w zadaniach automatyczny -> zmiana statusu przesyłki, oraz nowe waruneki dla zdarzenia "zmiana statusu przesyłki": przesyłka zarejestrowana, przesyłka do odbioru, przesyłka nadana w punkcie, przesyłka odebrana, przesyłka anulowana, przesyłka nieodebrana, przesyłka odebrana (zwrot), chyba że takich statusów się nie da to trzeba sprawdzić jakie się da.
+43. [x] Usuwanie wpisu z kolejki druku etykiet
+
+## SonarQube — pełna lista błędów (new code period, skan 2026-03-28)
+<!-- SONAR_ERRORS_START -->
+
+- Źródło: SonarQube API `issues/search` dla `orderPRO` (`inNewCodePeriod=true`)
+- Razem issue: 174
+- Severity: MAJOR=110, CRITICAL=47, MINOR=16, BLOCKER=1
+- Typy: CODE_SMELL=170, BUG=3, VULNERABILITY=1
+
+### Lista issue
+- [ ] [MINOR][BUG][php:S2003] resources/views/accounting/index.php:31 - Replace "require" with "require_once". (key: 6fe7d2de-4802-459e-a5a7-f9f1be183b8e)
+- [ ] [MINOR][BUG][php:S2003] resources/views/orders/show.php:780 - Replace "require" with "require_once". (key: 98cef6cd-bb23-4bc8-acd9-01d4417f25e6)
+- [ ] [MINOR][CODE_SMELL][Web:S6827] resources/views/layouts/app.php:80 - Anchors must have content and the content must be accessible by a screen reader. (key: 64d29d8b-146d-4a20-803d-4aeb035b0391)
+- [ ] [MINOR][CODE_SMELL][Web:S6827] resources/views/orders/receipt-create.php:123 - Anchors must have content and the content must be accessible by a screen reader. (key: bbd01366-d6f2-4745-b5b2-8b06c3aec574)
+- [ ] [MINOR][CODE_SMELL][Web:S6827] resources/views/orders/show.php:669 - Anchors must have content and the content must be accessible by a screen reader. (key: 351a396c-239c-468d-a1bf-391adabd1b0a)
+- [ ] [MINOR][CODE_SMELL][Web:S6827] resources/views/receipts/show.php:19 - Anchors must have content and the content must be accessible by a screen reader. (key: cb8922ca-ccc4-4518-9466-e9c40d0aec4b)
+- [ ] [MINOR][CODE_SMELL][Web:S6827] resources/views/receipts/show.php:20 - Anchors must have content and the content must be accessible by a screen reader. (key: 29dd7510-9b95-4f90-9f47-0cf39d6318f2)
+- [ ] [MINOR][CODE_SMELL][Web:S6827] resources/views/receipts/show.php:21 - Anchors must have content and the content must be accessible by a screen reader. (key: 15deb0d4-dae8-4ede-b371-969ed668e0b7)
+- [ ] [MINOR][CODE_SMELL][Web:S6827] resources/views/settings/accounting.php:50 - Anchors must have content and the content must be accessible by a screen reader. (key: cffe0ae9-1c3f-4e5b-99d9-3dd6d528252b)
+- [ ] [MINOR][CODE_SMELL][Web:S6827] resources/views/settings/accounting.php:133 - Anchors must have content and the content must be accessible by a screen reader. (key: 816ae9c0-c782-406f-a3b4-d6d810119ebd)
+- [ ] [MINOR][CODE_SMELL][Web:S6827] resources/views/settings/delivery-status-mappings.php:24 - Anchors must have content and the content must be accessible by a screen reader. (key: a6e860d2-54dd-485b-82db-79415b2d4cb7)
+- [ ] [MINOR][CODE_SMELL][Web:S6827] resources/views/settings/printing.php:138 - Anchors must have content and the content must be accessible by a screen reader. (key: 43949459-6186-48cf-b099-36064429e0dc)
+- [ ] [MINOR][CODE_SMELL][php:S1488] src/Modules/Accounting/ReceiptRepository.php:139 - Immediately return this expression instead of assigning it to the temporary variable "$number". (key: 4cf8b055-d030-4fe5-b917-c4eae64c2e4d)
+- [ ] [MINOR][CODE_SMELL][php:S1481] src/Modules/Settings/EmailTemplateController.php:91 - Remove this unused "$t" local variable. (key: 5e00928d-3bfa-40cb-82e3-f6d1886f8b09)
+- [ ] [MINOR][CODE_SMELL][php:S1481] src/Modules/Settings/ShopproIntegrationsController.php:118 - Remove this unused "$redirectBase" local variable. (key: 22a0c0d1-5edf-4a80-8e42-dcab51ec880b)
+- [ ] [MINOR][CODE_SMELL][php:S1481] src/Modules/Settings/ShopproIntegrationsController.php:185 - Remove this unused "$redirectBase" local variable. (key: 2d95f5c7-5f6b-4e60-a48e-59fe991831f3)
+- [ ] [MAJOR][CODE_SMELL][php:S4833] resources/views/accounting/index.php:31 - Replace "require" with namespace import mechanism through the "use" keyword. (key: 349e8aeb-dc6d-4ac9-9c7e-f9b4cab594aa)
+- [ ] [MAJOR][CODE_SMELL][php:S3358] resources/views/automation/form.php:6 - Extract this nested ternary operation into an independent statement. (key: d9b92d37-73d9-4d70-804a-bde593b3253f)
+- [ ] [MAJOR][CODE_SMELL][php:S3358] resources/views/automation/form.php:7 - Extract this nested ternary operation into an independent statement. (key: 21a944af-e4fe-427a-9b30-4fedfb9f2211)
+- [ ] [MAJOR][CODE_SMELL][php:S3358] resources/views/automation/form.php:64 - Extract this nested ternary operation into an independent statement. (key: e253095f-e15e-468a-ac77-e143109b17fc)
+- [ ] [MAJOR][CODE_SMELL][Web:S6819] resources/views/automation/index.php:21 - Use <output> instead of the status role to ensure accessibility across all devices. (key: 0ce5f805-0818-495e-b8d1-fe8049b91a75)
+- [ ] [MAJOR][CODE_SMELL][Web:S6853] resources/views/components/table-list.php:159 - A form label must be associated with a control and have accessible text. (key: b982e00b-4a3f-4e0c-bff4-f069fb33863a)
+- [ ] [MAJOR][CODE_SMELL][Web:S6853] resources/views/orders/partials/email-send-modal.php:32 - A form label must be associated with a control and have accessible text. (key: e7bef918-f0fa-4163-a0ef-a1ef85202dd7)
+- [ ] [MAJOR][CODE_SMELL][Web:S6853] resources/views/orders/partials/email-send-modal.php:36 - A form label must be associated with a control and have accessible text. (key: 3a807055-dbce-4e2b-a3d0-f464a1541203)
+- [ ] [MAJOR][CODE_SMELL][Web:S6853] resources/views/orders/partials/email-send-modal.php:45 - A form label must be associated with a control and have accessible text. (key: d0367ef9-f2f2-4fb6-bf5e-8f63fa365dc7)
+- [ ] [MAJOR][CODE_SMELL][php:S1066] resources/views/orders/show.php:232 - Merge this if statement with the enclosing one. (key: 60895f28-eb9d-4856-835f-ba52879ddf72)
+- [ ] [MAJOR][CODE_SMELL][php:S4833] resources/views/orders/show.php:780 - Replace "require" with namespace import mechanism through the "use" keyword. (key: 7811b6ca-5d01-4735-9210-ec33bda2cb15)
+- [ ] [MAJOR][CODE_SMELL][Web:S6819] resources/views/settings/accounting.php:15 - Use <output> instead of the status role to ensure accessibility across all devices. (key: 070e9668-dbf0-4289-810a-3cf82a63c4dc)
+- [ ] [MAJOR][CODE_SMELL][php:S3358] resources/views/settings/accounting.php:125 - Extract this nested ternary operation into an independent statement. (key: 423b1c28-9cec-42e5-a7d6-04c76b0d85d1)
+- [ ] [MAJOR][CODE_SMELL][Web:S6819] resources/views/settings/delivery-status-mappings.php:17 - Use <output> instead of the status role to ensure accessibility across all devices. (key: 8589b27e-9d53-4391-bb9a-62b51bef8a09)
+- [ ] [MAJOR][CODE_SMELL][Web:S6819] resources/views/settings/email-mailboxes.php:15 - Use <output> instead of the status role to ensure accessibility across all devices. (key: 8e8fe629-0de9-4d70-a5b8-226f1384abf3)
+- [ ] [MAJOR][CODE_SMELL][php:S3358] resources/views/settings/email-mailboxes.php:148 - Extract this nested ternary operation into an independent statement. (key: a74eedd7-a231-4881-965f-24e56c1be8e7)
+- [ ] [MAJOR][CODE_SMELL][Web:S6819] resources/views/settings/email-templates.php:18 - Use <output> instead of the status role to ensure accessibility across all devices. (key: 9c0e2dc4-5c2c-46b2-a8d7-7bb9d4315f81)
+- [ ] [MAJOR][CODE_SMELL][php:S3358] resources/views/settings/email-templates.php:115 - Extract this nested ternary operation into an independent statement. (key: 26857bc5-9bd2-4a33-86e6-060300b057fb)
+- [ ] [MAJOR][CODE_SMELL][Web:S6819] resources/views/settings/printing.php:16 - Use <output> instead of the status role to ensure accessibility across all devices. (key: 298ffe0f-babf-4b9f-b919-f4b113b374b0)
+- [ ] [MAJOR][CODE_SMELL][php:S108] src/Core/Application.php:305 - Either remove or fill this block of code. (key: 96a6ddf7-f8ef-44d9-b7ad-7a0121bb5dbf)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Accounting/ReceiptController.php:78 - This method has 5 returns, which is more than the 3 allowed. (key: 575a0744-73ce-4613-9695-1c738c76c6a8)
+- [ ] [MAJOR][CODE_SMELL][php:S1068] src/Modules/Automation/AutomationController.php:36 - Remove this unused "$translator" private field. (key: a0396a4b-e5b1-4170-8fc3-cfaec4b3dc30)
+- [ ] [MAJOR][CODE_SMELL][php:S1172] src/Modules/Automation/AutomationController.php:43 - Remove the unused function parameter "$request". (key: 65a90d6a-ad36-4447-b2f9-ecdc7ba8adde)
+- [ ] [MAJOR][CODE_SMELL][php:S1172] src/Modules/Automation/AutomationController.php:61 - Remove the unused function parameter "$request". (key: 870d63e8-0901-448f-94a1-0e8b01912dae)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Automation/AutomationController.php:106 - This method has 4 returns, which is more than the 3 allowed. (key: 607368ad-fb0c-4f55-a356-7a7bbb2171c5)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Automation/AutomationController.php:244 - This method has 5 returns, which is more than the 3 allowed. (key: 4f1cf18f-0bfb-464f-a91c-96d55f727407)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Automation/AutomationController.php:386 - This method has 5 returns, which is more than the 3 allowed. (key: 30a04d0a-c531-4afc-9ea7-b4e3fac8bc9b)
+- [ ] [MAJOR][CODE_SMELL][php:S112] src/Modules/Automation/AutomationRepository.php:133 - Define and throw a dedicated exception instead of using a generic one. (key: 3d4896bb-1b99-4ef1-9f5e-1882a2c96111)
+- [ ] [MAJOR][CODE_SMELL][php:S1448] src/Modules/Automation/AutomationService.php:13 - Class "AutomationService" has 24 methods, which is greater than 20 authorized. Split it into smaller classes. (key: 306419f7-dc3e-426b-9f2b-af3da48cf961)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Automation/AutomationService.php:143 - This method has 4 returns, which is more than the 3 allowed. (key: be2ee4d3-cd59-43cd-8953-cc2e61590751)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Automation/AutomationService.php:249 - This method has 4 returns, which is more than the 3 allowed. (key: a5b8e06b-0d6f-4867-b4f0-9717e074ac2e)
+- [ ] [MAJOR][CODE_SMELL][php:S1448] src/Modules/Cron/CronRepository.php:10 - Class "CronRepository" has 22 methods, which is greater than 20 authorized. Split it into smaller classes. (key: f57e5c77-cecf-4451-8cb4-9d3cd107743d)
+- [ ] [MAJOR][CODE_SMELL][php:S1172] src/Modules/Cron/ShipmentTrackingHandler.php:22 - Remove the unused function parameter "$payload". (key: df8cb6fd-8f1f-491b-9170-bcda370fcdc6)
+- [ ] [MAJOR][CODE_SMELL][php:S1172] src/Modules/Cron/ShipmentTrackingHandler.php:24 - Remove the unused function parameter "$_payload". (key: 4c8e00f0-d82a-4bb2-93e8-368acfddbc94)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Email/AttachmentGenerator.php:37 - This method has 5 returns, which is more than the 3 allowed. (key: ecc23d2e-409a-44da-855c-b0d1803b320c)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Email/EmailSendingService.php:31 - This method has 5 returns, which is more than the 3 allowed. (key: 6627aebd-7dce-4206-8dce-81fcdc7e0f65)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Email/EmailSendingService.php:165 - This method has 4 returns, which is more than the 3 allowed. (key: 3c755950-a760-48a2-806d-1c6977c5ab11)
+- [ ] [MAJOR][CODE_SMELL][php:S107] src/Modules/Email/EmailSendingService.php:293 - This function has 11 parameters, which is greater than the 7 authorized. (key: bf3c667b-fefc-4ecc-8cd3-46810cf07b11)
+- [ ] [MAJOR][CODE_SMELL][php:S1448] src/Modules/Orders/OrdersController.php:21 - Class "OrdersController" has 22 methods, which is greater than 20 authorized. Split it into smaller classes. (key: 8e4cf728-d4e5-41b9-9aee-e1f83b20fb98)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Orders/OrdersController.php:738 - This method has 5 returns, which is more than the 3 allowed. (key: 345e58a7-989a-4992-895d-e50e2aba8b5d)
+- [ ] [MAJOR][CODE_SMELL][php:S1448] src/Modules/Orders/OrdersRepository.php:10 - Class "OrdersRepository" has 29 methods, which is greater than 20 authorized. Split it into smaller classes. (key: 99a725d0-e52c-4511-b2fe-0124ea396530)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Orders/OrdersRepository.php:765 - This method has 6 returns, which is more than the 3 allowed. (key: dee0f8dc-13eb-4bb5-a113-283e103c3e8d)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Printing/ApiKeyMiddleware.php:16 - This method has 5 returns, which is more than the 3 allowed. (key: ad20b5d4-2e4f-45c6-b7d6-67971c8985bf)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Printing/PrintApiController.php:24 - This method has 4 returns, which is more than the 3 allowed. (key: 8a9d1c4c-d76d-48ed-93e7-6c6220e11b60)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Printing/PrintApiController.php:48 - This method has 6 returns, which is more than the 3 allowed. (key: 5239c52c-cdd7-4c54-995e-fc8c079d1f33)
+- [ ] [MAJOR][CODE_SMELL][php:S1172] src/Modules/Printing/PrintApiController.php:93 - Remove the unused function parameter "$request". (key: 9e2cd6a3-816f-4600-85c7-539ca9bffa72)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Printing/PrintApiController.php:110 - This method has 5 returns, which is more than the 3 allowed. (key: abd439dc-6d09-4b90-9dbb-9b3ad8e39b00)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/AllegroApiClient.php:174 - This method has 4 returns, which is more than the 3 allowed. (key: 65fef8f7-212e-43b9-87de-5e045ff990ea)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/AllegroDeliveryMappingController.php:107 - This method has 6 returns, which is more than the 3 allowed. (key: f5b84a65-0df5-4188-9795-826c12de4bf5)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/AllegroDeliveryMappingController.php:163 - This method has 4 returns, which is more than the 3 allowed. (key: 76e0cad6-338c-47f8-b19f-b23d379b25c4)
+- [ ] [MAJOR][CODE_SMELL][php:S1068] src/Modules/Settings/AllegroIntegrationController.php:54 - Remove this unused "$statusDiscoveryService" private field. (key: 7538d906-57ee-4332-9efe-93f818d96e15)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/AllegroIntegrationController.php:580 - This method has 5 returns, which is more than the 3 allowed. (key: 82bb5eef-a7e6-4d56-bc9d-1346dc6ae231)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/AllegroIntegrationController.php:601 - This method has 4 returns, which is more than the 3 allowed. (key: a83fb3eb-6b77-4e81-b88e-3603e25322d2)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/AllegroIntegrationController.php:? - This method has 6 returns, which is more than the 3 allowed. (key: 83c9cf56-26ac-4940-b95d-2c900e42842a)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/AllegroIntegrationController.php:? - This method has 4 returns, which is more than the 3 allowed. (key: 491a1bd5-469b-4cfc-91dd-0c3c42308f9a)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/AllegroOAuthClient.php:129 - This method has 4 returns, which is more than the 3 allowed. (key: 1327860b-f1fe-4afe-93bb-d7e7942deb18)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/AllegroOrderSyncStateRepository.php:116 - This method has 5 returns, which is more than the 3 allowed. (key: e07bea6a-b47c-4569-8424-7f3aad44dd91)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/AllegroStatusMappingController.php:24 - This method has 5 returns, which is more than the 3 allowed. (key: bdc7b785-b0f6-44da-a9aa-9141cbaa797a)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/AllegroStatusMappingController.php:60 - This method has 4 returns, which is more than the 3 allowed. (key: 9d61f6f0-681f-426a-ad7d-5c92ebe5d9f9)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/AllegroStatusSyncService.php:95 - This method has 4 returns, which is more than the 3 allowed. (key: 3ea41fce-c3e4-4130-b663-07e3539437a2)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/AllegroTokenManager.php:22 - This method has 4 returns, which is more than the 3 allowed. (key: b40ca0bb-c268-434f-85e5-23ed04992e74)
+- [ ] [MAJOR][CODE_SMELL][php:S112] src/Modules/Settings/AllegroTokenManager.php:? - Define and throw a dedicated exception instead of using a generic one. (key: a90b3b80-375d-4b74-aa15-9d0dbed5a668)
+- [ ] [MAJOR][CODE_SMELL][php:S112] src/Modules/Settings/AllegroTokenManager.php:? - Define and throw a dedicated exception instead of using a generic one. (key: 48f9a5e2-ed3f-4559-9236-f5d6cfb4d184)
+- [ ] [MAJOR][CODE_SMELL][php:S112] src/Modules/Settings/AllegroTokenManager.php:? - Define and throw a dedicated exception instead of using a generic one. (key: 55989bbe-7ca8-4507-8ce1-60bfe9f787ba)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/ApaczkaApiClient.php:12 - This method has 4 returns, which is more than the 3 allowed. (key: 3aaf7471-390f-4da6-9787-e2a90d85e757)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/DeliveryStatusMappingController.php:78 - This method has 4 returns, which is more than the 3 allowed. (key: 80297fac-393a-4c1f-9fdd-4c2c178b606f)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/EmailMailboxController.php:51 - This method has 5 returns, which is more than the 3 allowed. (key: 2fa910d3-968b-418b-8e72-a1583a704103)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/EmailMailboxController.php:149 - This method has 10 returns, which is more than the 3 allowed. (key: 970d4c0a-02d0-4d5a-ba4a-9d186ca91827)
+- [ ] [MAJOR][CODE_SMELL][php:S3358] src/Modules/Settings/EmailMailboxController.php:173 - Extract this nested ternary operation into an independent statement. (key: 24f6a171-bd8f-4277-8664-2f4561db7499)
+- [ ] [MAJOR][CODE_SMELL][php:S1172] src/Modules/Settings/EmailMailboxController.php:184 - Remove the unused function parameter "$errno". (key: e10d7439-6df7-4ed0-af9d-be43df3d0ad0)
+- [ ] [MAJOR][CODE_SMELL][php:S1066] src/Modules/Settings/EmailMailboxController.php:213 - Merge this if statement with the enclosing one. (key: 73174936-1909-41e0-93f6-27cd62529463)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/EmailTemplateController.php:180 - This method has 4 returns, which is more than the 3 allowed. (key: beec3100-a5ac-432f-a951-48e9b7e1454e)
+- [ ] [MAJOR][CODE_SMELL][php:S1172] src/Modules/Settings/EmailTemplateController.php:238 - Remove the unused function parameter "$request". (key: 2377826f-4c53-4fd9-83c8-e3b3a3cf160f)
+- [ ] [MAJOR][CODE_SMELL][php:S112] src/Modules/Settings/EmailTemplateRepository.php:127 - Define and throw a dedicated exception instead of using a generic one. (key: f1d48d68-eb1c-4ed0-a4aa-8b1f9b3795be)
+- [ ] [MAJOR][CODE_SMELL][php:S1068] src/Modules/Settings/PrintSettingsController.php:20 - Remove this unused "$translator" private field. (key: 1f25c1d8-16b8-491e-90b7-bf0729829270)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/ReceiptConfigController.php:51 - This method has 4 returns, which is more than the 3 allowed. (key: 87ef6d59-5e41-4aa4-892b-fe434f1a6d33)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/ShopproApiClient.php:8 - This method has 4 returns, which is more than the 3 allowed. (key: d94d5549-57ce-4f6a-8f20-3f9e3ad1e398)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/ShopproApiClient.php:271 - This method has 6 returns, which is more than the 3 allowed. (key: 4adaba8d-505d-4021-964c-e759f5b643e2)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/ShopproIntegrationsController.php:417 - This method has 6 returns, which is more than the 3 allowed. (key: afeb41a5-6952-4bfb-9b33-3a6cd21a0164)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/ShopproIntegrationsController.php:845 - This method has 4 returns, which is more than the 3 allowed. (key: 4ba1161c-abf6-4962-a271-c3a9a036f89e)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/ShopproIntegrationsController.php:892 - This method has 4 returns, which is more than the 3 allowed. (key: ee0d2f35-63fe-4820-bbca-f37c80507ba8)
+- [ ] [MAJOR][CODE_SMELL][php:S1448] src/Modules/Settings/ShopproOrderMapper.php:9 - Class "ShopproOrderMapper" has 25 methods, which is greater than 20 authorized. Split it into smaller classes. (key: e132d4d8-d7ef-43d9-9a56-bc73e29f04b5)
+- [ ] [MAJOR][CODE_SMELL][php:S1066] src/Modules/Settings/ShopproOrderMapper.php:124 - Merge this if statement with the enclosing one. (key: 55b645d7-a07c-46bf-9650-6ee814db3823)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/ShopproOrderMapper.php:756 - This method has 5 returns, which is more than the 3 allowed. (key: 5d78c738-b8c0-4d64-bf60-d845a3ff79e5)
+- [ ] [MAJOR][CODE_SMELL][php:S107] src/Modules/Settings/ShopproOrdersSyncService.php:148 - This function has 12 parameters, which is greater than the 7 authorized. (key: d752676c-26a9-41dc-9fc2-25fed7279945)
+- [ ] [MAJOR][CODE_SMELL][php:S107] src/Modules/Settings/ShopproOrdersSyncService.php:205 - This function has 10 parameters, which is greater than the 7 authorized. (key: 8833dfe4-f5d4-41a8-9562-3900907ae83e)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/ShopproOrderSyncStateRepository.php:28 - This method has 6 returns, which is more than the 3 allowed. (key: 8f905c07-78cf-4821-91c0-07a00bf81294)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/ShopproOrderSyncStateRepository.php:119 - This method has 4 returns, which is more than the 3 allowed. (key: 568faf2a-c596-4a6d-a93b-3068ffb59018)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/ShopproOrderSyncStateRepository.php:187 - This method has 5 returns, which is more than the 3 allowed. (key: 1f865f5f-133c-4c6e-9f71-2bc16e67cf5c)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/ShopproOrderSyncStateRepository.php:233 - This method has 4 returns, which is more than the 3 allowed. (key: 78fdff90-b4e2-4788-badf-3e9c6120095d)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/ShopproProductImageResolver.php:67 - This method has 5 returns, which is more than the 3 allowed. (key: 3487bf7b-14b8-4a14-a7d5-04a06352f4e8)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/ShopproProductImageResolver.php:100 - This method has 4 returns, which is more than the 3 allowed. (key: 610094af-d885-41a3-882d-5f80b1811756)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Settings/ShopproStatusSyncService.php:85 - This method has 5 returns, which is more than the 3 allowed. (key: b96494b7-0abc-4a3c-850e-917ebb967162)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Shipments/AllegroTrackingService.php:? - This method has 4 returns, which is more than the 3 allowed. (key: fb96d9eb-76a8-4bed-bed8-51e40fb34637)
+- [ ] [MAJOR][CODE_SMELL][php:S1172] src/Modules/Shipments/ApaczkaShipmentService.php:? - Remove the unused function parameter "$pickupDate". (key: 89c3519a-8fd8-4f4b-8441-31dd1964d5c9)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Shipments/ApaczkaTrackingService.php:? - This method has 6 returns, which is more than the 3 allowed. (key: 7e398dc8-ba2c-46b5-a92b-c6215b5dae89)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Shipments/DeliveryStatus.php:298 - This method has 5 returns, which is more than the 3 allowed. (key: 826ef8c0-6ae2-4e6e-9362-efedcd7d4b3e)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Shipments/DeliveryStatus.php:325 - This method has 9 returns, which is more than the 3 allowed. (key: aa388daa-f00e-420e-890d-296d0bf887b7)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Shipments/InpostShipmentService.php:162 - This method has 4 returns, which is more than the 3 allowed. (key: d6f7b0db-a66b-463f-a468-453d8c5e77e2)
+- [ ] [MAJOR][CODE_SMELL][php:S108] src/Modules/Shipments/InpostShipmentService.php:259 - Either remove or fill this block of code. (key: 2c40580b-b1c5-46d1-99de-0ef17482c4fa)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Shipments/InpostShipmentService.php:379 - This method has 4 returns, which is more than the 3 allowed. (key: 50211ce3-df60-4509-8006-0731330b33db)
+- [ ] [MAJOR][CODE_SMELL][php:S3358] src/Modules/Shipments/InpostShipmentService.php:430 - Extract this nested ternary operation into an independent statement. (key: 5e93d138-15b2-42e2-aea8-cdb65fe73093)
+- [ ] [MAJOR][CODE_SMELL][php:S3358] src/Modules/Shipments/InpostShipmentService.php:464 - Extract this nested ternary operation into an independent statement. (key: b4019378-ddc0-49d1-aa5b-f207191c25b9)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Shipments/InpostShipmentService.php:481 - This method has 4 returns, which is more than the 3 allowed. (key: 52ab972c-121e-4ff9-845a-44a370a78d21)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Shipments/InpostTrackingService.php:? - This method has 5 returns, which is more than the 3 allowed. (key: 79ec448a-2ccf-425e-b891-b5b575d32014)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Shipments/InpostTrackingService.php:? - This method has 4 returns, which is more than the 3 allowed. (key: 25da7c1f-e8c4-4093-88e7-6273943092aa)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Shipments/InpostTrackingService.php:? - This method has 4 returns, which is more than the 3 allowed. (key: ad271852-0406-4aaa-b5bf-63c27b87c997)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Shipments/ShipmentController.php:341 - This method has 4 returns, which is more than the 3 allowed. (key: ac28cbe9-96be-4cbd-bcc4-8c61a3de54fe)
+- [ ] [MAJOR][CODE_SMELL][php:S1172] src/Modules/Shipments/ShipmentPresetController.php:16 - Remove the unused function parameter "$request". (key: ca0f98ed-fd61-45c7-9983-1be5c4a3dc61)
+- [ ] [MAJOR][CODE_SMELL][php:S1142] src/Modules/Shipments/ShipmentPresetController.php:36 - This method has 4 returns, which is more than the 3 allowed. (key: cafb4b15-3a32-4df7-89ed-fca044b6b2f2)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] resources/views/automation/form.php:56 - Define a constant instead of duplicating this literal " selected" 10 times. (key: 1b785bca-9189-4e51-a983-1a6cd1ed413e)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] resources/views/automation/form.php:64 - Define a constant instead of duplicating this literal " checked" 4 times. (key: f778b6e9-59c2-451f-b966-ee339dc056b3)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] resources/views/settings/accounting.php:97 - Define a constant instead of duplicating this literal " selected" 8 times. (key: 1a039950-d513-403d-a535-63b84457aba0)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] resources/views/settings/accounting.php:121 - Define a constant instead of duplicating this literal " checked" 3 times. (key: 9d152206-5833-4ae7-9814-39101c81a252)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] resources/views/settings/email-mailboxes.php:121 - Define a constant instead of duplicating this literal " selected" 3 times. (key: 771b71dd-2b2e-46fe-a5a7-e58821c8b635)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] resources/views/settings/email-mailboxes.php:144 - Define a constant instead of duplicating this literal " checked" 3 times. (key: 8da76115-87b8-4eef-8448-b76492ddc805)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Accounting/AccountingController.php:51 - Define a constant instead of duplicating this literal "/accounting" 3 times. (key: 538274f1-117d-46cc-9898-95d01f1e7507)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Accounting/ReceiptController.php:38 - Define a constant instead of duplicating this literal "Not found" 5 times. (key: b2e1a08e-86f5-4429-8b0d-5c1d4896a59d)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Accounting/ReceiptController.php:44 - Define a constant instead of duplicating this literal "/orders/" 5 times. (key: 33203616-3238-415e-9883-1699fa6de54f)
+- [ ] [CRITICAL][CODE_SMELL][php:S3776] src/Modules/Accounting/ReceiptController.php:78 - Refactor this function to reduce its Cognitive Complexity from 21 to the 15 allowed. (key: f3ebebf5-028b-4dde-a2ba-ef10a0020ada)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Automation/AutomationController.php:73 - Define a constant instead of duplicating this literal "/settings/automation" 11 times. (key: f522e45e-6882-4185-ac9e-38ea4a482c82)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Automation/AutomationController.php:115 - Define a constant instead of duplicating this literal "Nieprawidlowy identyfikator" 4 times. (key: 9939d997-5fab-4101-b18a-a7a9c88a273c)
+- [ ] [CRITICAL][CODE_SMELL][php:S3776] src/Modules/Cron/ShipmentTrackingHandler.php:24 - Refactor this function to reduce its Cognitive Complexity from 27 to the 15 allowed. (key: c46115eb-4adf-4c9d-b25d-c5523ed6f685)
+- [ ] [CRITICAL][CODE_SMELL][php:S3776] src/Modules/Orders/OrdersController.php:153 - Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed. (key: 1b2e554e-f3ef-4c84-8ee1-d4d896150e59)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Orders/OrdersController.php:158 - Define a constant instead of duplicating this literal "Not found" 3 times. (key: 3c5e48e3-b063-4ea1-9b91-6cac61975952)
+- [ ] [CRITICAL][CODE_SMELL][php:S3776] src/Modules/Orders/OrdersController.php:244 - Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed. (key: 72e50aff-63c1-4b6d-92e9-506a97020d17)
+- [ ] [CRITICAL][CODE_SMELL][php:S3776] src/Modules/Printing/PrintApiController.php:? - Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed. (key: eef29972-3369-4b8e-ae62-6e00d8f90770)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Settings/AllegroApiClient.php:239 - Define a constant instead of duplicating this literal "Accept: application/vnd.allegro.public.v1+json" 3 times. (key: 90cf597b-cda9-431f-aaf6-2ccc9caf53ad)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Settings/AllegroApiClient.php:240 - Define a constant instead of duplicating this literal "Content-Type: application/vnd.allegro.public.v1+json" 3 times. (key: a4185ddd-bfd0-42e8-91af-d876eabaa82f)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Settings/AllegroApiClient.php:256 - Define a constant instead of duplicating this literal "Nieprawidlowy JSON odpowiedzi API Allegro." 3 times. (key: d982750f-ff14-4e16-ad00-a1c89004ed3c)
+- [ ] [CRITICAL][CODE_SMELL][php:S3776] src/Modules/Settings/AllegroApiClient.php:288 - Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed. (key: 463978ad-d6dd-4fde-a4ec-518f58ed863a)
+- [ ] [CRITICAL][CODE_SMELL][php:S3776] src/Modules/Settings/AllegroStatusSyncService.php:95 - Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed. (key: 722dad21-32a3-4ed6-b50e-0d1b56972c97)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Settings/DeliveryStatusMappingController.php:91 - Define a constant instead of duplicating this literal "Brakuje wymaganych pA3l." 3 times. (key: ed96e62c-f7b6-49b1-943a-d0ddffe3320f)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Settings/DeliveryStatusMappingController.php:92 - Define a constant instead of duplicating this literal "?provider=" 8 times. (key: 96f81947-608e-45cc-a136-4870e961017d)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Settings/EmailMailboxController.php:54 - Define a constant instead of duplicating this literal "Nieprawidlowy token CSRF" 4 times. (key: 13fa7ac0-bcae-4a86-ab23-3c68cab37be0)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Settings/EmailMailboxController.php:55 - Define a constant instead of duplicating this literal "/settings/email-mailboxes" 11 times. (key: f1865646-c867-4852-8957-3e99ebed3392)
+- [ ] [CRITICAL][CODE_SMELL][php:S3776] src/Modules/Settings/EmailMailboxController.php:149 - Refactor this function to reduce its Cognitive Complexity from 27 to the 15 allowed. (key: 375ad9aa-aedc-4b27-84ff-9f2c513322e1)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Settings/EmailTemplateController.php:122 - Define a constant instead of duplicating this literal "Nieprawidlowy token CSRF" 5 times. (key: d707b40d-21df-4531-b377-bb28188d7fb4)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Settings/EmailTemplateController.php:123 - Define a constant instead of duplicating this literal "/settings/email-templates" 9 times. (key: 5883ebc3-beb0-4e69-acf7-2ce30a969e0f)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Settings/PrintSettingsController.php:57 - Define a constant instead of duplicating this literal "/settings/printing" 9 times. (key: 1767bc02-e977-418f-8014-4c07097ea449)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Settings/ReceiptConfigController.php:54 - Define a constant instead of duplicating this literal "Nieprawidlowy token CSRF" 3 times. (key: 540bfead-9d65-4e6b-bd1f-ca39977ac9f9)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Settings/ReceiptConfigController.php:55 - Define a constant instead of duplicating this literal "/settings/accounting" 10 times. (key: a20a4e43-843e-4e37-b19f-9abf814a1003)
+- [ ] [CRITICAL][CODE_SMELL][php:S3776] src/Modules/Settings/ShopproApiClient.php:271 - Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed. (key: fae0cfa7-6155-4594-8b82-37224777f0e7)
+- [ ] [CRITICAL][CODE_SMELL][php:S3776] src/Modules/Settings/ShopproOrderMapper.php:61 - Refactor this function to reduce its Cognitive Complexity from 28 to the 15 allowed. (key: c4359cde-57d2-471b-96e5-33878b57343a)
+- [ ] [CRITICAL][CODE_SMELL][php:S3776] src/Modules/Settings/ShopproOrderMapper.php:527 - Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed. (key: a8351c51-818c-464c-bc58-3ee72da58ca3)
+- [ ] [CRITICAL][CODE_SMELL][php:S3776] src/Modules/Settings/ShopproOrdersSyncService.php:148 - Refactor this function to reduce its Cognitive Complexity from 21 to the 15 allowed. (key: 88925e9b-05a0-404e-a5ff-f941c2f5a556)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Settings/ShopproOrderSyncStateRepository.php:83 - Define a constant instead of duplicating this literal "Y-m-d H:i:s" 6 times. (key: eceb259a-a9fb-482f-b603-7415b57763f0)
+- [ ] [CRITICAL][CODE_SMELL][php:S3776] src/Modules/Settings/ShopproProductImageResolver.php:18 - Refactor this function to reduce its Cognitive Complexity from 25 to the 15 allowed. (key: 1eb00e5e-7193-4e11-8f6c-c0e546d2a585)
+- [ ] [CRITICAL][CODE_SMELL][php:S3776] src/Modules/Settings/ShopproProductImageResolver.php:67 - Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed. (key: bcc3a574-e087-4800-8051-063192de45b4)
+- [ ] [CRITICAL][CODE_SMELL][php:S3776] src/Modules/Settings/ShopproStatusSyncService.php:85 - Refactor this function to reduce its Cognitive Complexity from 22 to the 15 allowed. (key: a809b285-820d-4cd4-9adc-d67ae5550df7)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Shipments/DeliveryStatus.php:30 - Define a constant instead of duplicating this literal "W dorÄ?czeniu" 3 times. (key: eaeb76a3-3eb1-4ac2-9df4-7483fdb22772)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Shipments/DeliveryStatus.php:32 - Define a constant instead of duplicating this literal "DorÄ?czona" 5 times. (key: 9d4c98c6-6fb8-40ef-853a-2e5be1d042cc)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Shipments/DeliveryStatus.php:87 - Define a constant instead of duplicating this literal "Odebrana przez kuriera" 3 times. (key: 818a994a-9c79-4dbb-9fa9-ed4700c97235)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Shipments/DeliveryStatus.php:102 - Define a constant instead of duplicating this literal "ZwrA3cona do nadawcy" 4 times. (key: 1873fbed-290e-4268-8a76-bb485bdc343a)
+- [ ] [CRITICAL][CODE_SMELL][php:S3776] src/Modules/Shipments/InpostShipmentService.php:48 - Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed. (key: 5ed92ef6-d6ae-46f5-b142-658d66290655)
+- [ ] [CRITICAL][CODE_SMELL][php:S1192] src/Modules/Shipments/InpostShipmentService.php:177 - Define a constant instead of duplicating this literal "/shipments/" 3 times. (key: 60eb2ce3-d818-4199-8c2d-6157360e309c)
+- [ ] [CRITICAL][VULNERABILITY][php:S4423] src/Modules/Settings/EmailMailboxController.php:223 - Change this code to use a stronger protocol. (key: 225d34b5-726e-4ace-aeba-5f9ca4d669dd)
+- [ ] [BLOCKER][BUG][php:S5911] src/Modules/Settings/AllegroOrderImportService.php:? - Create class "RuntimeException" in namespace or check correct import of class (key: 1ac28e27-43e6-4115-af21-aa08f65d068e)
+
+<!-- SONAR_ERRORS_END -->
+
+
+47. [x] Zadania automatyczne: nowe zdarzenie Utworzenie przesylki uruchamiane od razu po utworzeniu paczki oraz nowa akcja Zmiana statusu przesylki.
+48. [x] Szablony e-mail: dodane zmienne `{{przesylka.numer}}` i `{{przesylka.link_sledzenia}}` z linkiem zaleznym od kuriera/providera.
--- a/.paul/governance/governance_2026-04-08.jsonl
+++ b/.paul/governance/governance_2026-04-08.jsonl
@@ -0,0 +1,38 @@
+{"ts":"2026-04-08T11:59:13Z","tool":"Bash","cmd":"mkdir -p \"/c/visual studio code/projekty/orderPRO/.paul/phases/86-apaczka-cod-bank-account\"\",\"description\":\"Create phase 86 directory\"},\"tool_response\":{\"stdout\":\"\",\"stderr\":\"\",\"inte","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T11:59:42Z","tool":"Write","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\.paul\\\\phases\\\\86-apaczka-cod-bank-account\\\\86-01-PLAN.md","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:00:00Z","tool":"Write","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\.paul\\\\STATE.md","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:00:01Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\.paul\\\\ROADMAP.md","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:01:21Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\src\\\\Modules\\\\Shipments\\\\ApaczkaShipmentService.php","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:01:27Z","tool":"Bash","cmd":"cd \"/c/visual studio code/projekty/orderPRO\" && /c/xampp/php/php.exe -l src/Modules/Shipments/ApaczkaShipmentService.php\",\"description\":\"PHP syntax check\"},\"tool_response\":{\"stdout\":\"No sy","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:01:41Z","tool":"Write","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\.paul\\\\STATE.md","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:04:10Z","tool":"Bash","cmd":"cd \"/c/visual studio code/projekty/orderPRO\" && curl -s -u \"www@orderpro.projectpro.pl:TcVVuQD2ppdGQWnwZv6j\" \"ftp://host700513.hostido.net.pl/public_html/src/Modules/Shipments/ApaczkaShipmentServ","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:04:56Z","tool":"Bash","cmd":"/c/xampp/mysql/bin/mysql.exe -h host700513.hostido.net.pl -u host700513_orderpro -p'hrDNtUBg9grwZ7syN77S' host700513_orderpro -e \"SELECT bank_account, bank_owner_name FROM company_settings LIMIT 1;\"","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:05:08Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\src\\\\Modules\\\\Shipments\\\\ApaczkaShipmentService.php","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:05:19Z","tool":"Bash","cmd":"/c/xampp/php/php.exe -l \"/c/visual studio code/projekty/orderPRO/src/Modules/Shipments/ApaczkaShipmentService.php\"\",\"description\":\"PHP syntax check\"},\"tool_response\":{\"stdout\":\"No syntax e","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:05:21Z","tool":"Bash","cmd":"cd \"/c/visual studio code/projekty/orderPRO\" && curl -s -T \"src/Modules/Shipments/ApaczkaShipmentService.php\" -u \"www@orderpro.projectpro.pl:TcVVuQD2ppdGQWnwZv6j\" \"ftp://host700513.hostido.net.","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:05:29Z","tool":"Bash","cmd":"curl -s -u \"www@orderpro.projectpro.pl:TcVVuQD2ppdGQWnwZv6j\" \"ftp://host700513.hostido.net.pl/public_html/src/Modules/Shipments/ApaczkaShipmentService.php\" 2>/dev/null | grep -n \"bank_account\"\"","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:08:06Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\src\\\\Modules\\\\Shipments\\\\ApaczkaShipmentService.php","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:08:15Z","tool":"Bash","cmd":"cd \"/c/visual studio code/projekty/orderPRO\" && curl -s -T \"src/Modules/Shipments/ApaczkaShipmentService.php\" -u \"www@orderpro.projectpro.pl:TcVVuQD2ppdGQWnwZv6j\" \"ftp://host700513.hostido.net.","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:08:23Z","tool":"Bash","cmd":"curl -s -u \"www@orderpro.projectpro.pl:TcVVuQD2ppdGQWnwZv6j\" \"ftp://host700513.hostido.net.pl/public_html/src/Modules/Shipments/ApaczkaShipmentService.php\" 2>/dev/null | grep -n \"bankaccount\"\",","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:09:32Z","tool":"Write","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\.paul\\\\phases\\\\86-apaczka-cod-bank-account\\\\86-01-SUMMARY.md","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:09:45Z","tool":"Write","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\.paul\\\\STATE.md","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:09:46Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\.paul\\\\ROADMAP.md","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:09:48Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\.paul\\\\PROJECT.md","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:09:55Z","tool":"Bash","cmd":"mkdir -p \"/c/visual studio code/projekty/orderPRO/.paul/changelog\"\",\"description\":\"Create changelog directory\"},\"tool_response\":{\"stdout\":\"\",\"stderr\":\"\",\"interrupted\":false,\"isImag","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T12:10:02Z","tool":"Write","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\.paul\\\\changelog\\\\2026-04-08.md","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T16:18:02Z","tool":"Bash","cmd":"mkdir -p \"/c/visual studio code/projekty/orderPRO/.paul/phases/87-shipment-delete\"\",\"description\":\"Create phase 87 directory\"},\"tool_response\":{\"stdout\":\"\",\"stderr\":\"\",\"interrupted\"","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T16:18:44Z","tool":"Write","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\.paul\\\\phases\\\\87-shipment-delete\\\\87-01-PLAN.md","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T16:18:56Z","tool":"Write","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\.paul\\\\STATE.md","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T16:18:57Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\.paul\\\\ROADMAP.md","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T16:19:22Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\src\\\\Modules\\\\Shipments\\\\ShipmentPackageRepository.php","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T16:19:43Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\src\\\\Modules\\\\Shipments\\\\ShipmentController.php","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T16:19:48Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\routes\\\\web.php","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T16:20:07Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\resources\\\\views\\\\orders\\\\show.php","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T16:20:12Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\resources\\\\views\\\\orders\\\\show.php","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T16:20:28Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\resources\\\\views\\\\orders\\\\show.php","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T16:20:40Z","tool":"Write","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\.paul\\\\STATE.md","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T16:21:51Z","tool":"Write","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\.paul\\\\phases\\\\87-shipment-delete\\\\87-01-SUMMARY.md","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T16:22:01Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\.paul\\\\PROJECT.md","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T16:22:03Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\.paul\\\\ROADMAP.md","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T16:22:14Z","tool":"Write","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\.paul\\\\STATE.md","cwd":"/c/visual studio code/projekty/orderPRO"}
+{"ts":"2026-04-08T16:22:25Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\orderPRO\\\\.paul\\\\changelog\\\\2026-04-08.md","cwd":"/c/visual studio code/projekty/orderPRO"}
--- a/.paul/phases/86-apaczka-cod-bank-account/86-01-PLAN.md
+++ b/.paul/phases/86-apaczka-cod-bank-account/86-01-PLAN.md
@@ -0,0 +1,108 @@
+---
+phase: 86-apaczka-cod-bank-account
+plan: 01
+type: execute
+wave: 1
+depends_on: []
+files_modified:
+  - src/Modules/Shipments/ApaczkaShipmentService.php
+autonomous: true
+delegation: off
+---
+
+<objective>
+## Goal
+Naprawic blad API Apaczka "Wprowadzono niepoprawny numer konta bankowego w usludze pobranie" przy tworzeniu przesylki COD — dodac `bank_account_number` do payloadu COD.
+
+## Purpose
+Uzytkownik nie moze tworzyc przesylek z pobraniem (COD) przez Apaczke. Blokuje to codzienna obsluge zamowien.
+
+## Output
+Poprawiony `ApaczkaShipmentService.php` — payload COD zawiera numer konta bankowego z ustawien firmy.
+</objective>
+
+<context>
+## Project Context
+@.paul/PROJECT.md
+@.paul/ROADMAP.md
+@.paul/STATE.md
+
+## Source Files
+@src/Modules/Shipments/ApaczkaShipmentService.php (linie 114-119 — budowanie payloadu COD)
+@src/Modules/Settings/CompanySettingsRepository.php (linia 45 — pole `bank_account`)
+</context>
+
+<acceptance_criteria>
+
+## AC-1: Payload COD zawiera numer konta bankowego
+```gherkin
+Given zamowienie z kwota pobrania (cod_amount > 0)
+  And ustawienia firmy zawieraja niepusty bank_account
+When ApaczkaShipmentService buduje payload COD
+Then obiekt cod zawiera pole bank_account_number z numerem konta z ustawien firmy
+```
+
+## AC-2: Brak konta bankowego — czytelny blad
+```gherkin
+Given zamowienie z kwota pobrania (cod_amount > 0)
+  And ustawienia firmy nie zawieraja bank_account (pusty string)
+When ApaczkaShipmentService buduje payload COD
+Then rzucony zostaje ShipmentException z komunikatem o braku numeru konta bankowego w ustawieniach firmy
+```
+
+</acceptance_criteria>
+
+<tasks>
+
+<task type="auto">
+  <name>Task 1: Dodac bank_account_number do payloadu COD w ApaczkaShipmentService</name>
+  <files>src/Modules/Shipments/ApaczkaShipmentService.php</files>
+  <action>
+    W metodzie `createShipment()`, w bloku `if ($codAmount > 0)` (linie 114-119):
+    1. Pobrac ustawienia firmy: `$settings = $this->companySettings->getSettings();`
+    2. Wyciagnac numer konta: `$bankAccount = $settings['bank_account'] ?? '';`
+    3. Jezeli `$bankAccount === ''` — rzucic `ShipmentException` z komunikatem:
+       "Przesylka COD wymaga numeru konta bankowego. Uzupelnij go w Ustawienia > Firma."
+    4. Dodac do tablicy `$apiPayload['cod']` pole `'bank_account_number' => $bankAccount`
+    5. Numer konta powinien byc przekazany jako czysty ciag cyfr (bez spacji/myslnikow) — uzyc `preg_replace('/\s+/', '', $bankAccount)`
+
+    Uwaga: NIE zmieniaj nic poza blokiem COD. Nie dodawaj nowych use statements (ShipmentException juz jest zaimportowany).
+  </action>
+  <verify>
+    Statyczna analiza: php -l src/Modules/Shipments/ApaczkaShipmentService.php
+    Manualna weryfikacja: utworzyc przesylke COD w zamowieniu #191 — API Apaczka nie powinno zwracac bledu o niepoprawnym koncie bankowym.
+  </verify>
+  <done>AC-1 i AC-2 spelnione: payload COD zawiera bank_account_number, brak konta = czytelny blad</done>
+</task>
+
+</tasks>
+
+<boundaries>
+
+## DO NOT CHANGE
+- src/Modules/Settings/CompanySettingsRepository.php (ustawienia firmy dzialaja poprawnie)
+- resources/views/shipments/prepare.php (formularz przygotowania przesylki)
+- src/Modules/Settings/ApaczkaApiClient.php (klient API)
+
+## SCOPE LIMITS
+- Nie dodawac pola bank_account do formularza przesylki — numer konta jest globalny (ustawienia firmy)
+- Nie zmieniac logiki innych providerow (InPost, Allegro)
+
+</boundaries>
+
+<verification>
+Before declaring plan complete:
+- [ ] `php -l src/Modules/Shipments/ApaczkaShipmentService.php` — brak bledow skladni
+- [ ] Payload COD zawiera `bank_account_number` z ustawien firmy
+- [ ] Pusty bank_account rzuca ShipmentException z czytelnym komunikatem
+- [ ] Zadne inne pliki nie zostaly zmienione
+</verification>
+
+<success_criteria>
+- Przesylka COD przez Apaczke tworzy sie bez bledu "niepoprawny numer konta bankowego"
+- Brak numeru konta w ustawieniach = czytelny komunikat zamiast bledu API
+</success_criteria>
+
+<output>
+After completion, create `.paul/phases/86-apaczka-cod-bank-account/86-01-SUMMARY.md`
+</output>
--- a/.paul/phases/86-apaczka-cod-bank-account/86-01-SUMMARY.md
+++ b/.paul/phases/86-apaczka-cod-bank-account/86-01-SUMMARY.md
@@ -0,0 +1,109 @@
+---
+phase: 86-apaczka-cod-bank-account
+plan: 01
+subsystem: shipments
+tags: [apaczka, cod, api]
+
+requires:
+  - phase: none
+    provides: n/a
+provides:
+  - Apaczka COD shipments include bank account number from company settings
+affects: []
+
+tech-stack:
+  added: []
+  patterns: []
+
+key-files:
+  created: []
+  modified:
+    - src/Modules/Shipments/ApaczkaShipmentService.php
+
+key-decisions:
+  - "Field name `bankaccount` per Apaczka API v2 docs (not `bank_account_number`)"
+  - "Strip all non-digit chars from bank account (handles PL prefix and spaces)"
+
+patterns-established: []
+
+duration: ~15min
+started: 2026-04-08T00:00:00Z
+completed: 2026-04-08T00:00:00Z
+---
+
+# Phase 86 Plan 01: Apaczka COD Bank Account Summary
+
+**Naprawiono blad API Apaczka przy tworzeniu przesylki COD — dodano pole `bankaccount` z numerem konta z ustawien firmy do payloadu COD.**
+
+## Performance
+
+| Metric | Value |
+|--------|-------|
+| Duration | ~15min |
+| Tasks | 1 completed |
+| Files modified | 1 |
+
+## Acceptance Criteria Results
+
+| Criterion | Status | Notes |
+|-----------|--------|-------|
+| AC-1: Payload COD zawiera numer konta bankowego | Pass | Pole `bankaccount` z 26 cyframi z company_settings |
+| AC-2: Brak konta = czytelny blad | Pass | ShipmentException z komunikatem o uzupelnieniu konta |
+
+## Accomplishments
+
+- Naprawiono blad API Apaczka "Wprowadzono niepoprawny numer konta bankowego w usludze pobranie"
+- Payload COD zawiera pole `bankaccount` z numerem konta oczyszczonym do samych cyfr
+- Brak numeru konta w ustawieniach firmy rzuca czytelny ShipmentException
+
+## Files Created/Modified
+
+| File | Change | Purpose |
+|------|--------|---------|
+| `src/Modules/Shipments/ApaczkaShipmentService.php` | Modified | Dodano `bankaccount` do payloadu COD + walidacje braku konta |
+
+## Decisions Made
+
+| Decision | Rationale | Impact |
+|----------|-----------|--------|
+| Pole `bankaccount` zamiast `bank_account_number` | Oficjalna dokumentacja Apaczka API v2 definiuje pole jako `bankaccount` (bez underscore) | Poprawne dzialanie COD |
+| `preg_replace('/[^0-9]/', '')` do czyszczenia numeru konta | Numer w bazie zawiera prefix PL i spacje (`PL22 2530...`), API wymaga 26 cyfr | Uniwersalne czyszczenie dowolnego formatu IBAN |
+
+## Deviations from Plan
+
+### Summary
+
+| Type | Count | Impact |
+|------|-------|--------|
+| Auto-fixed | 1 | Krytyczne — bledna nazwa pola API |
+
+### Auto-fixed Issues
+
+**1. Bledna nazwa pola API `bank_account_number` -> `bankaccount`**
+- **Found during:** Testowanie na serwerze produkcyjnym
+- **Issue:** Pole `bank_account_number` nie jest rozpoznawane przez Apaczka API v2
+- **Fix:** Zmieniono na `bankaccount` zgodnie z oficjalna dokumentacja API
+- **Verification:** Uzytkownik potwierdzil poprawne tworzenie przesylki COD
+
+## Issues Encountered
+
+| Issue | Resolution |
+|-------|------------|
+| `uploadOnSave: false` — plik nie synchronizowal sie automatycznie z serwerem | Reczny upload przez FTP curl |
+| Numer konta w bazie z prefixem PL i spacjami | Regex `[^0-9]` usuwa wszystko poza cyframi |
+| Nazwa pola API `bank_account_number` niepoprawna | Sprawdzono oficjalna dokumentacje — prawidlowe pole to `bankaccount` |
+
+## Next Phase Readiness
+
+**Ready:**
+- Przesylki COD przez Apaczke dzialaja poprawnie
+
+**Concerns:**
+- Brak
+
+**Blockers:**
+- None
+
+---
+*Phase: 86-apaczka-cod-bank-account, Plan: 01*
+*Completed: 2026-04-08*
--- a/.paul/phases/87-shipment-delete/87-01-PLAN.md
+++ b/.paul/phases/87-shipment-delete/87-01-PLAN.md
@@ -0,0 +1,163 @@
+---
+phase: 87-shipment-delete
+plan: 01
+type: execute
+wave: 1
+depends_on: []
+files_modified:
+  - src/Modules/Shipments/ShipmentPackageRepository.php
+  - src/Modules/Shipments/ShipmentController.php
+  - routes/web.php
+  - resources/views/orders/show.php
+autonomous: true
+delegation: off
+---
+
+<objective>
+## Goal
+Dodanie możliwości usuwania przesyłek (shipment_packages) z zakładki Przesyłki w szczegółach zamówienia, z pytaniem potwierdzającym przed usunięciem.
+
+## Purpose
+Użytkownik potrzebuje możliwości usunięcia błędnie utworzonej lub niepotrzebnej przesyłki bez konieczności ingerencji w bazę danych.
+
+## Output
+- Przycisk "Usuń" przy każdej przesyłce w tabeli na /orders/{id}#shipments
+- Potwierdzenie przez OrderProAlerts.confirm przed wysłaniem żądania
+- Endpoint POST /orders/{id}/shipment/{packageId}/delete z walidacją CSRF
+- Usunięcie rekordu z shipment_packages + pliku etykiety (jeśli istnieje)
+- Wpis w activity log zamówienia
+</objective>
+
+<context>
+## Project Context
+@.paul/PROJECT.md
+@.paul/ROADMAP.md
+@.paul/STATE.md
+
+## Source Files
+@src/Modules/Shipments/ShipmentPackageRepository.php
+@src/Modules/Shipments/ShipmentController.php
+@routes/web.php
+@resources/views/orders/show.php
+</context>
+
+<skills>
+No specialized flows required.
+</skills>
+
+<acceptance_criteria>
+
+## AC-1: Przycisk usuwania widoczny przy przesyłce
+```gherkin
+Given zamówienie ma co najmniej jedną przesyłkę w shipment_packages
+When użytkownik otwiera szczegóły zamówienia i zakładkę Przesyłki
+Then przy każdej przesyłce w tabeli "Wygenerowane przesylki" widoczny jest przycisk "Usuń"
+```
+
+## AC-2: Potwierdzenie przed usunięciem
+```gherkin
+Given użytkownik widzi przycisk "Usuń" przy przesyłce
+When kliknie przycisk "Usuń"
+Then wyświetla się okno potwierdzenia OrderProAlerts.confirm z pytaniem "Czy na pewno chcesz usunąć tę przesyłkę?"
+And przesyłka NIE jest usuwana dopóki użytkownik nie potwierdzi
+```
+
+## AC-3: Usunięcie przesyłki po potwierdzeniu
+```gherkin
+Given użytkownik potwierdził usunięcie przesyłki
+When żądanie POST trafia do /orders/{id}/shipment/{packageId}/delete
+Then rekord shipment_packages jest usuwany z bazy danych
+And plik etykiety (label_path) jest usuwany z dysku (jeśli istnieje)
+And w activity log zamówienia pojawia się wpis "shipment_deleted"
+And użytkownik jest przekierowany z powrotem na /orders/{id} z komunikatem sukcesu
+```
+
+</acceptance_criteria>
+
+<tasks>
+
+<task type="auto">
+  <name>Task 1: Backend — repository delete + controller endpoint + route</name>
+  <files>src/Modules/Shipments/ShipmentPackageRepository.php, src/Modules/Shipments/ShipmentController.php, routes/web.php</files>
+  <action>
+    1. ShipmentPackageRepository — dodaj metodę `delete(int $id): void`:
+       - DELETE FROM shipment_packages WHERE id = :id
+       - Prepared statement, spójne z resztą repo
+
+    2. ShipmentController — dodaj metodę `delete(Request $request): Response`:
+       - Pobierz orderId i packageId z requestu
+       - Waliduj CSRF token (wzorzec z metody create)
+       - Pobierz pakiet przez packageRepository->findById
+       - Sprawdź czy pakiet istnieje i należy do tego zamówienia (order_id match)
+       - Jeśli label_path istnieje na dysku — usuń plik (unlink)
+       - Wywołaj packageRepository->delete($packageId)
+       - Zapisz activity log: ordersRepository->recordActivity($orderId, 'shipment_deleted', opis z tracking_number/provider/id, null, 'user', $actorName)
+       - Flash::set('order.success', 'Przesylka zostala usunieta.')
+       - Redirect do /orders/{orderId}
+
+    3. routes/web.php — dodaj route tuż po linii z /shipment/manual:
+       - $router->post('/orders/{id}/shipment/{packageId}/delete', [$shipmentController, 'delete'], [$authMiddleware]);
+  </action>
+  <verify>Grep for 'delete' in ShipmentController.php and ShipmentPackageRepository.php; check route in web.php</verify>
+  <done>AC-3 satisfied: przesyłka usuwana z DB, etykieta z dysku, activity log zapisany, redirect z flash message</done>
+</task>
+
+<task type="auto">
+  <name>Task 2: Frontend — przycisk Usuń z potwierdzeniem w widoku zamówienia</name>
+  <files>resources/views/orders/show.php</files>
+  <action>
+    W tabeli "Wygenerowane przesylki" (sekcja packagesList), dodaj kolumnę "Akcje" w thead.
+    W tbody, w nowej kolumnie dla każdej przesyłki dodaj formularz POST:
+    - action="/orders/{orderId}/shipment/{packageId}/delete"
+    - hidden _token (CSRF)
+    - przycisk "Usuń" klasy btn btn--sm btn--danger
+    - Na submit formularza: event.preventDefault(), wywołaj window.OrderProAlerts.confirm z pytaniem "Czy na pewno chcesz usunąć tę przesyłkę?" i w onConfirm: form.submit()
+
+    Skrypt JS inline (lub w bloku script na dole) obsługujący confirm:
+    - Delegacja na .btn-delete-package click
+    - preventDefault, pobranie closest form
+    - OrderProAlerts.confirm({title: 'Usuwanie przesyłki', message: 'Czy na pewno chcesz usunąć tę przesyłkę?', onConfirm: () => form.submit()})
+  </action>
+  <verify>Otworzyć /orders/{id} z przesyłkami — widoczny przycisk Usuń, kliknięcie pokazuje confirm dialog</verify>
+  <done>AC-1 i AC-2 satisfied: przycisk widoczny, potwierdzenie wymagane przed usunięciem</done>
+</task>
+
+</tasks>
+
+<boundaries>
+
+## DO NOT CHANGE
+- shipment_packages table schema (no migrations)
+- Logika tworzenia przesyłek (create, createManual)
+- Sekcja "Wysylki z Allegro" (to dane zewnętrzne, nie lokalne pakiety)
+- Automation triggers (nie emituj eventu przy usuwaniu)
+
+## SCOPE LIMITS
+- Usuwanie dotyczy tylko rekordów z tabeli shipment_packages (lokalne przesyłki)
+- Nie usuwamy przesyłek z API przewoźnika (tylko lokalny rekord)
+- Brak soft-delete — twarde usunięcie z bazy
+
+</boundaries>
+
+<verification>
+Before declaring plan complete:
+- [ ] Metoda delete() w ShipmentPackageRepository działa (prepared statement)
+- [ ] Endpoint POST /orders/{id}/shipment/{packageId}/delete zwraca redirect
+- [ ] CSRF walidacja działa (bez tokena = błąd)
+- [ ] Plik etykiety usuwany z dysku gdy istnieje
+- [ ] Activity log zapisany po usunięciu
+- [ ] Przycisk "Usuń" widoczny w tabeli przesyłek
+- [ ] OrderProAlerts.confirm wyświetla się przed usunięciem
+- [ ] Wszystkie acceptance criteria spełnione
+</verification>
+
+<success_criteria>
+- Wszystkie zadania ukończone
+- Wszystkie weryfikacje przeszły
+- Brak błędów PHP/JS
+- Przesyłka usuwana po potwierdzeniu, z cleanup etykiety i wpisem w logu
+</success_criteria>
+
+<output>
+After completion, create `.paul/phases/87-shipment-delete/87-01-SUMMARY.md`
+</output>
--- a/.paul/phases/87-shipment-delete/87-01-SUMMARY.md
+++ b/.paul/phases/87-shipment-delete/87-01-SUMMARY.md
@@ -0,0 +1,100 @@
+---
+phase: 87-shipment-delete
+plan: 01
+subsystem: shipments
+tags: [php, shipment-packages, crud, ui]
+
+requires: []
+provides:
+  - Usuwanie przesylek z poziomu szczegolow zamowienia
+affects: []
+
+tech-stack:
+  added: []
+  patterns: [OrderProAlerts.confirm for destructive actions]
+
+key-files:
+  created: []
+  modified:
+    - src/Modules/Shipments/ShipmentPackageRepository.php
+    - src/Modules/Shipments/ShipmentController.php
+    - routes/web.php
+    - resources/views/orders/show.php
+
+key-decisions:
+  - "Hard delete z bazy (bez soft-delete) — spójne z resztą systemu"
+  - "Usuwanie tylko lokalnego rekordu, bez kasowania z API przewoźnika"
+
+patterns-established: []
+
+duration: ~5min
+started: 2026-04-08T00:00:00Z
+completed: 2026-04-08T00:00:00Z
+---
+
+# Phase 87 Plan 01: Shipment Delete Summary
+
+**Usuwanie przesyłek z zakładki Przesyłki w szczegółach zamówienia z potwierdzeniem OrderProAlerts.confirm**
+
+## Performance
+
+| Metric | Value |
+|--------|-------|
+| Duration | ~5min |
+| Tasks | 2 completed |
+| Files modified | 4 |
+
+## Acceptance Criteria Results
+
+| Criterion | Status | Notes |
+|-----------|--------|-------|
+| AC-1: Przycisk usuwania widoczny przy przesyłce | Pass | Kolumna Akcje z przyciskiem "Usun" btn--danger |
+| AC-2: Potwierdzenie przed usunięciem | Pass | OrderProAlerts.confirm z fallback na native confirm |
+| AC-3: Usunięcie przesyłki po potwierdzeniu | Pass | DELETE z DB, cleanup etykiety, activity log, flash + redirect |
+
+## Accomplishments
+
+- Endpoint POST `/orders/{id}/shipment/{packageId}/delete` z walidacją CSRF i owner check
+- Cleanup pliku etykiety z dysku przy usunięciu
+- Activity log `shipment_deleted` z tracking number i provider info
+- Przycisk "Usun" z dialogiem potwierdzenia w tabeli przesyłek
+
+## Files Created/Modified
+
+| File | Change | Purpose |
+|------|--------|---------|
+| `src/Modules/Shipments/ShipmentPackageRepository.php` | Modified | Metoda `delete(int $id): void` |
+| `src/Modules/Shipments/ShipmentController.php` | Modified | Metoda `delete()` — CSRF, owner check, label cleanup, activity log |
+| `routes/web.php` | Modified | Route POST `/orders/{id}/shipment/{packageId}/delete` |
+| `resources/views/orders/show.php` | Modified | Kolumna Akcje, przycisk Usun, JS confirm handler |
+
+## Decisions Made
+
+| Decision | Rationale | Impact |
+|----------|-----------|--------|
+| Hard delete (nie soft-delete) | Spójne z resztą systemu, brak potrzeby historii usuniętych | Prostsze, activity log zachowuje ślad |
+| Brak kasowania z API przewoźnika | Usuwamy tylko lokalny rekord; przesyłka u przewoźnika istnieje niezależnie | Bezpieczne — nie wpływa na realną przesyłkę |
+| Fallback na native confirm | Na wypadek gdyby OrderProAlerts nie był załadowany | Robustność |
+
+## Deviations from Plan
+
+None — plan executed exactly as written.
+
+## Issues Encountered
+
+None.
+
+## Next Phase Readiness
+
+**Ready:**
+- Funkcjonalność usuwania przesyłek kompletna i gotowa do użycia
+
+**Concerns:**
+- None
+
+**Blockers:**
+- None
+
+---
+*Phase: 87-shipment-delete, Plan: 01*
+*Completed: 2026-04-08*