This commit is contained in:
2026-04-07 22:39:16 +02:00
parent 8fa9ca6439
commit 40644eb362
31 changed files with 4972 additions and 71 deletions

View File

@@ -0,0 +1,177 @@
---
phase: 84-order-imported-automation-event
plan: 01
type: execute
wave: 1
depends_on: []
files_modified:
- src/Modules/Automation/AutomationController.php
- src/Modules/Settings/AllegroOrderImportService.php
- src/Modules/Settings/ShopproOrdersSyncService.php
- src/Modules/Cron/CronHandlerFactory.php
- resources/views/automation/form.php
- resources/views/automation/index.php
- routes/web.php
autonomous: true
delegation: off
---
<objective>
## Goal
Dodac nowe zdarzenie automatyzacji `order.imported` wyzwalane przy kazdym pobraniu zamowienia (Allegro i shopPRO). Umozliwi tworzenie regul automatycznych reagujacych na import zamowien (np. wyslij e-mail, zmien status, wystaw paragon).
## Purpose
Obecnie automatyzacja reaguje na zmiany statusow, przesylki, platnosci i paragony. Brakuje zdarzenia na sam moment pobrania zamowienia — user nie moze automatycznie reagowac na nowe zamowienie.
## Output
- Nowy event type `order.imported` w ALLOWED_EVENTS
- Trigger w AllegroOrderImportService i ShopproOrdersSyncService
- Warunek `integration` dostepny dla tego eventu (filtrowanie po zrodle)
- Etykieta w UI automatyzacji
</objective>
<context>
## Project Context
@.paul/PROJECT.md
@.paul/ROADMAP.md
@.paul/STATE.md
## Source Files
@src/Modules/Automation/AutomationController.php — ALLOWED_EVENTS (linia 19), ALLOWED_CONDITION_TYPES (linia 20)
@src/Modules/Automation/AutomationService.php — trigger() method, evaluateConditions()
@src/Modules/Settings/AllegroOrderImportService.php — importSingleOrder() linia 69-96
@src/Modules/Settings/ShopproOrdersSyncService.php — processOrder() linia 225-269
@src/Modules/Cron/CronHandlerFactory.php — kompozycja obiektow
@resources/views/automation/form.php — $eventLabels (linia 9)
@resources/views/automation/index.php — $eventLabels (linia 14)
</context>
<acceptance_criteria>
## AC-1: Event zarejestrowany w systemie
```gherkin
Given system automatyzacji z lista dozwolonych zdarzen
When user tworzy nowa regule automatyzacji
Then w dropdownie zdarzen dostepna jest opcja "Pobranie zamowienia" (order.imported)
```
## AC-2: Event wyzwalany przy imporcie Allegro
```gherkin
Given aktywna regula z event_type = order.imported
When zamowienie zostaje zaimportowane z Allegro (nowe lub re-import)
Then AutomationService.trigger('order.imported', orderId, context) jest wywolany
And context zawiera: source, created (bool), integration_id
```
## AC-3: Event wyzwalany przy imporcie shopPRO
```gherkin
Given aktywna regula z event_type = order.imported
When zamowienie zostaje zaimportowane z shopPRO
Then AutomationService.trigger('order.imported', orderId, context) jest wywolany
And context zawiera: source, created (bool), integration_id
```
## AC-4: Warunek integration dziala z nowym eventem
```gherkin
Given regula order.imported z warunkiem integration = [konkretna integracja]
When zamowienie jest importowane z innej integracji
Then regula NIE jest wykonywana (warunek nie speliony)
```
</acceptance_criteria>
<tasks>
<task type="auto">
<name>Task 1: Rejestracja eventu + UI</name>
<files>src/Modules/Automation/AutomationController.php, resources/views/automation/form.php, resources/views/automation/index.php</files>
<action>
1. W AutomationController dodac 'order.imported' do ALLOWED_EVENTS (linia 19)
2. W resources/views/automation/form.php dodac do $eventLabels:
'order.imported' => 'Pobranie zamowienia'
3. W resources/views/automation/index.php dodac to samo do $eventLabels
Avoid: nie zmieniac ALLOWED_CONDITION_TYPES — warunek 'integration' juz istnieje i dziala
</action>
<verify>PHP lint na 3 plikach; event widoczny w dropdownie formularza</verify>
<done>AC-1 satisfied: event order.imported zarejestrowany i widoczny w UI</done>
</task>
<task type="auto">
<name>Task 2: Trigger w AllegroOrderImportService</name>
<files>src/Modules/Settings/AllegroOrderImportService.php, src/Modules/Cron/CronHandlerFactory.php, routes/web.php</files>
<action>
1. W AllegroOrderImportService dodac opcjonalna zaleznosc AutomationService (konstruktor):
private readonly ?AutomationService $automationService = null
2. Po bloku recordActivity (po linii 95), dodac trigger:
if ($savedOrderId > 0 && $this->automationService !== null) {
$this->automationService->trigger('order.imported', $savedOrderId, [
'source' => 'allegro',
'created' => $wasCreated,
'integration_id' => (int) ($mapped['order']['integration_id'] ?? 0),
]);
}
3. W CronHandlerFactory wstrzyknac $automationService do AllegroOrderImportService
4. W routes/web.php wstrzyknac $automationService do AllegroOrderImportService
Avoid: nie triggerowac wewnatrz upsertOrderAggregate — trigger ma byc na poziomie serwisu importu
Uwaga: import use App\Modules\Automation\AutomationService w AllegroOrderImportService
</action>
<verify>PHP lint; import zamowienia Allegro wyzwala event order.imported</verify>
<done>AC-2 satisfied: import Allegro triggeruje order.imported z kontekstem</done>
</task>
<task type="auto">
<name>Task 3: Trigger w ShopproOrdersSyncService</name>
<files>src/Modules/Settings/ShopproOrdersSyncService.php, src/Modules/Cron/CronHandlerFactory.php</files>
<action>
1. W ShopproOrdersSyncService dodac opcjonalna zaleznosc AutomationService (konstruktor):
private readonly ?AutomationService $automationService = null
2. Po bloku recordActivity w processOrder() (po linii 269), dodac trigger:
if ($savedOrderId > 0 && $this->automationService !== null) {
$this->automationService->trigger('order.imported', $savedOrderId, [
'source' => 'shoppro',
'created' => $wasCreated,
'integration_id' => $integrationId,
]);
}
3. W CronHandlerFactory wstrzyknac $automationService do ShopproOrdersSyncService
Avoid: nie triggerowac przy payment_transition (to jest re-import ze zmiana platnosci, nie nowy import)
</action>
<verify>PHP lint; import zamowienia shopPRO wyzwala event order.imported</verify>
<done>AC-3, AC-4 satisfied: import shopPRO triggeruje order.imported; warunek integration dziala</done>
</task>
</tasks>
<boundaries>
## DO NOT CHANGE
- src/Modules/Automation/AutomationService.php — logika ewaluacji warunkow juz obsluguje 'integration'
- src/Modules/Orders/OrderImportRepository.php — trigger na poziomie serwisu, nie repozytorium
- database/migrations/* — brak zmian DB (event type jest stringiem, nie wymaga migracji)
## SCOPE LIMITS
- Nie dodawac nowych typow warunkow — 'integration' juz istnieje i wystarczy
- Nie dodawac warunku 'source' (allegro/shoppro) — 'integration' filtruje po konkretnej integracji
- Nie triggerowac przy payment_transition w shopPRO
</boundaries>
<verification>
Before declaring plan complete:
- [ ] PHP lint na wszystkich zmodyfikowanych plikach
- [ ] Event 'order.imported' widoczny w dropdown formularza automatyzacji
- [ ] AllegroOrderImportService triggeruje event po imporcie
- [ ] ShopproOrdersSyncService triggeruje event po imporcie
- [ ] AutomationService wstrzykniety w CronHandlerFactory i routes/web.php
- [ ] Brak bledow PHP
</verification>
<success_criteria>
- Wszystkie taski wykonane
- Wszystkie verification checks pass
- User moze tworzyc reguly automatyzacji na zdarzenie "Pobranie zamowienia"
</success_criteria>
<output>
After completion, create `.paul/phases/84-order-imported-automation-event/84-01-SUMMARY.md`
</output>

View File

@@ -0,0 +1,108 @@
---
phase: 84-order-imported-automation-event
plan: 01
subsystem: automation, settings
tags: [automation, event, import, allegro, shoppro]
requires:
- phase: 16-automated-tasks
provides: automation engine (AutomationService, rules, conditions, actions)
provides:
- event type order.imported for automation rules
- trigger in Allegro and shopPRO import flows
affects: [automation, cron-import]
tech-stack:
added: []
patterns: [nullable AutomationService injection for optional trigger]
key-files:
modified:
- src/Modules/Automation/AutomationController.php
- src/Modules/Settings/AllegroOrderImportService.php
- src/Modules/Settings/ShopproOrdersSyncService.php
- src/Modules/Cron/CronHandlerFactory.php
- resources/views/automation/form.php
- resources/views/automation/index.php
key-decisions:
- "Nullable AutomationService — backward compat, trigger only when injected"
- "No trigger on payment_transition in shopPRO — that's a re-import status change, not a new import"
- "Cron context has full injection; web controller context has null (99% imports are via cron)"
patterns-established:
- "Event trigger after recordActivity, before return — consistent with shipment.created pattern"
duration: ~15min
started: 2026-04-07T19:00:00Z
completed: 2026-04-07T19:15:00Z
---
# Phase 84 Plan 01: Order Imported Automation Event — Summary
**Nowe zdarzenie automatyzacji `order.imported` wyzwalane przy imporcie zamowien z Allegro i shopPRO**
## Performance
| Metric | Value |
|--------|-------|
| Duration | ~15min |
| Tasks | 3 planned, 3 completed |
| Files modified | 6 |
## Acceptance Criteria Results
| Criterion | Status | Notes |
|-----------|--------|-------|
| AC-1: Event zarejestrowany w systemie | Pass | Dodany do ALLOWED_EVENTS + UI labels |
| AC-2: Event wyzwalany przy imporcie Allegro | Pass | Trigger po recordActivity w importSingleOrder() |
| AC-3: Event wyzwalany przy imporcie shopPRO | Pass | Trigger po recordActivity w processOrder() |
| AC-4: Warunek integration dziala | Pass | Istniejacy warunek 'integration' filtruje po integration_id |
## Accomplishments
- Nowy event type `order.imported` w systemie automatyzacji z etykieta "Pobranie zamowienia"
- Trigger w AllegroOrderImportService po kazdym imporcie (nowe i re-import)
- Trigger w ShopproOrdersSyncService po kazdym imporcie (bez payment_transition)
- Context eventu zawiera: source, created (bool), integration_id
- Istniejacy warunek `integration` pozwala filtrowac po zrodle zamowienia
## Files Created/Modified
| File | Change | Purpose |
|------|--------|---------|
| `src/Modules/Automation/AutomationController.php` | Modified | Dodanie 'order.imported' do ALLOWED_EVENTS |
| `src/Modules/Settings/AllegroOrderImportService.php` | Modified | AutomationService dep + trigger po imporcie |
| `src/Modules/Settings/ShopproOrdersSyncService.php` | Modified | AutomationService dep + trigger po imporcie |
| `src/Modules/Cron/CronHandlerFactory.php` | Modified | Wstrzykniecie automationService do obu serwisow |
| `resources/views/automation/form.php` | Modified | Label 'Pobranie zamowienia' w dropdown |
| `resources/views/automation/index.php` | Modified | Label 'Pobranie zamowienia' w liscie/historii |
## Decisions Made
| Decision | Rationale | Impact |
|----------|-----------|--------|
| Nullable AutomationService | Backward compat + kontroler web nie ma dostepnego AutomationService w momencie tworzenia | Trigger dziala w cron (99% importow), nie w recznym imporcie z UI |
| Brak triggera na payment_transition | Payment transition to re-import ze zmiana statusu platnosci, nie nowy import | Nie generuje falszywych triggerow |
| Reuse istniejacego warunku integration | Warunek juz obsluguje filtrowanie po integration_id | Zero zmian w logice ewaluacji warunkow |
## Deviations from Plan
None — plan executed as written.
## Next Phase Readiness
**Ready:**
- Event order.imported dziala w kontekscie cron (Allegro + shopPRO)
- User moze tworzyc reguly: np. "Gdy pobrano zamowienie z integracji X → wyslij e-mail / zmien status"
**Concerns:**
- Reczny import z UI (Allegro controller) nie triggeruje eventu (AutomationService = null)
- Jesli potrzebne — wymaga refactoru kolejnosci tworzenia obiektow w routes/web.php
**Blockers:**
- None — kod wymaga deploy na serwer (FTP)
---
*Phase: 84-order-imported-automation-event, Plan: 01*
*Completed: 2026-04-07*