ver. 0.293: Code review fixes — 6 repositories, 16 fixes
- ArticleRepository: SQL injection fix (addslashes→parameterized), DRY refactor topArticles/newsListArticles
- AttributeRepository: dead class_exists('\S') blocking cache/temp clear
- CategoryRepository: dead class_exists('\S') blocking SEO link generation (critical)
- BannerRepository: parameterize $today in SQL + null guard on query()
- BasketCalculator: null guard checkProductQuantityInStock + optional DI params
- PromotionRepository: null guard on $basket (production fatal)
- OrderRepository/ShopBasketController/ajax.php: explicit DI in BasketCalculator callers
614 tests, 1821 assertions (+4 new)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -938,14 +938,8 @@ class AttributeRepository
|
||||
|
||||
private function clearTempAndCache(): void
|
||||
{
|
||||
if (class_exists('\S')) {
|
||||
if (method_exists('\S', 'delete_dir')) {
|
||||
\Shared\Helpers\Helpers::delete_dir('../temp/');
|
||||
}
|
||||
if (method_exists('\S', 'delete_cache')) {
|
||||
\Shared\Helpers\Helpers::delete_cache();
|
||||
}
|
||||
}
|
||||
\Shared\Helpers\Helpers::delete_dir('../temp/');
|
||||
\Shared\Helpers\Helpers::delete_cache();
|
||||
}
|
||||
|
||||
private function normalizeDecimal(float $value, int $precision = 2): float
|
||||
|
||||
Reference in New Issue
Block a user