ver. 0.293: Code review fixes — 6 repositories, 16 fixes
- ArticleRepository: SQL injection fix (addslashes→parameterized), DRY refactor topArticles/newsListArticles
- AttributeRepository: dead class_exists('\S') blocking cache/temp clear
- CategoryRepository: dead class_exists('\S') blocking SEO link generation (critical)
- BannerRepository: parameterize $today in SQL + null guard on query()
- BasketCalculator: null guard checkProductQuantityInStock + optional DI params
- PromotionRepository: null guard on $basket (production fatal)
- OrderRepository/ShopBasketController/ajax.php: explicit DI in BasketCalculator callers
614 tests, 1821 assertions (+4 new)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -668,18 +668,12 @@ class CategoryRepository
|
||||
|
||||
private function refreshCategoryArtifacts(): void
|
||||
{
|
||||
if (class_exists('\\S')) {
|
||||
\Shared\Helpers\Helpers::htacces();
|
||||
\Shared\Helpers\Helpers::delete_dir('../temp/');
|
||||
}
|
||||
\Shared\Helpers\Helpers::htacces();
|
||||
\Shared\Helpers\Helpers::delete_dir('../temp/');
|
||||
}
|
||||
|
||||
private function normalizeSeoLink($value): ?string
|
||||
{
|
||||
if (!class_exists('\\S')) {
|
||||
return $this->toNullableString($value);
|
||||
}
|
||||
|
||||
$seo = \Shared\Helpers\Helpers::seo((string)$value);
|
||||
$seo = trim((string)$seo);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user