Project-Pro/shopPRO
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor newsletter module and disable prepare/user templates

Browse Source
This commit is contained in:
Jacek Pyziak
2026-02-12 23:26:28 +01:00
parent b0a2f4be0e
commit 0d4e175b1a
26 changed files with 1182 additions and 602 deletions
Download Patch File Download Diff File Expand all files Collapse all files

78
tests/Unit/Domain/Newsletter/NewsletterRepositoryTest.php Normal file
View File

@@ -0,0 +1,78 @@
<?php
namespace Tests\Unit\Domain\Newsletter;
use PHPUnit\Framework\TestCase;
use Domain\Newsletter\NewsletterRepository;
use Domain\Settings\SettingsRepository;
class NewsletterRepositoryTest extends TestCase
{
public function testTemplateDetailsReturnsNullForInvalidId(): void
{
$mockDb = $this->createMock(\medoo::class);
$repository = new NewsletterRepository($mockDb, $this->createMock(SettingsRepository::class));
$this->assertNull($repository->templateDetails(0));
}
public function testTemplateDetailsReturnsArray(): void
{
$mockDb = $this->createMock(\medoo::class);
$mockDb->expects($this->once())
->method('get')
->with('pp_newsletter_templates', '*', ['id' => 7])
->willReturn(['id' => 7, 'name' => 'Tpl']);
$repository = new NewsletterRepository($mockDb, $this->createMock(SettingsRepository::class));
$details = $repository->templateDetails(7);
$this->assertIsArray($details);
$this->assertSame(7, $details['id']);
}
public function testSaveSettingsUpdatesHeaderAndFooter(): void
{
$mockDb = $this->createMock(\medoo::class);
$settingsRepository = $this->createMock(SettingsRepository::class);
$settingsRepository->expects($this->exactly(2))
->method('updateSetting')
->withConsecutive(
['newsletter_footer', 'Footer'],
['newsletter_header', 'Header']
);
$repository = new NewsletterRepository($mockDb, $settingsRepository);
$this->assertTrue($repository->saveSettings([
'newsletter_header' => 'Header',
'newsletter_footer' => 'Footer',
]));
}
public function testDeleteTemplateReturnsFalseForAdminTemplate(): void
{
$mockDb = $this->createMock(\medoo::class);
$mockDb->expects($this->once())
->method('get')
->with('pp_newsletter_templates', 'is_admin', ['id' => 5])
->willReturn(1);
$repository = new NewsletterRepository($mockDb, $this->createMock(SettingsRepository::class));
$this->assertFalse($repository->deleteTemplate(5));
}
public function testTemplateByNameReturnsText(): void
{
$mockDb = $this->createMock(\medoo::class);
$mockDb->expects($this->once())
->method('get')
->with('pp_newsletter_templates', 'text', ['name' => '#abc'])
->willReturn('Template text');
$repository = new NewsletterRepository($mockDb, $this->createMock(SettingsRepository::class));
$this->assertSame('Template text', $repository->templateByName('#abc'));
}
}

70
tests/Unit/admin/Controllers/NewsletterControllerTest.php Normal file
View File

@@ -0,0 +1,70 @@
<?php
namespace Tests\Unit\admin\Controllers;
use PHPUnit\Framework\TestCase;
use admin\Controllers\NewsletterController;
use Domain\Newsletter\NewsletterRepository;
use Domain\Newsletter\NewsletterPreviewRenderer;
class NewsletterControllerTest extends TestCase
{
private $repository;
private $previewRenderer;
private $controller;
protected function setUp(): void
{
$this->repository = $this->createMock(NewsletterRepository::class);
$this->previewRenderer = $this->createMock(NewsletterPreviewRenderer::class);
$this->controller = new NewsletterController($this->repository, $this->previewRenderer);
}
public function testConstructorAcceptsDependencies(): void
{
$controller = new NewsletterController($this->repository, $this->previewRenderer);
$this->assertInstanceOf(NewsletterController::class, $controller);
}
public function testHasMainActionMethods(): void
{
$this->assertTrue(method_exists($this->controller, 'emails_list'));
$this->assertTrue(method_exists($this->controller, 'prepare'));
$this->assertTrue(method_exists($this->controller, 'send'));
$this->assertTrue(method_exists($this->controller, 'preview'));
$this->assertTrue(method_exists($this->controller, 'settings'));
$this->assertTrue(method_exists($this->controller, 'settings_save'));
$this->assertTrue(method_exists($this->controller, 'email_templates_user'));
$this->assertTrue(method_exists($this->controller, 'email_templates_admin'));
$this->assertTrue(method_exists($this->controller, 'email_template_edit'));
$this->assertTrue(method_exists($this->controller, 'template_save'));
$this->assertTrue(method_exists($this->controller, 'email_template_delete'));
}
public function testActionMethodReturnTypes(): void
{
$reflection = new \ReflectionClass($this->controller);
$this->assertEquals('string', (string)$reflection->getMethod('emails_list')->getReturnType());
$this->assertEquals('string', (string)$reflection->getMethod('prepare')->getReturnType());
$this->assertEquals('void', (string)$reflection->getMethod('send')->getReturnType());
$this->assertEquals('string', (string)$reflection->getMethod('preview')->getReturnType());
$this->assertEquals('string', (string)$reflection->getMethod('settings')->getReturnType());
$this->assertEquals('void', (string)$reflection->getMethod('settings_save')->getReturnType());
$this->assertEquals('string', (string)$reflection->getMethod('email_templates_user')->getReturnType());
$this->assertEquals('string', (string)$reflection->getMethod('email_templates_admin')->getReturnType());
$this->assertEquals('string', (string)$reflection->getMethod('email_template_edit')->getReturnType());
$this->assertEquals('void', (string)$reflection->getMethod('template_save')->getReturnType());
$this->assertEquals('void', (string)$reflection->getMethod('email_template_delete')->getReturnType());
}
public function testConstructorRequiresRepositoryAndRenderer(): void
{
$reflection = new \ReflectionClass(NewsletterController::class);
$constructor = $reflection->getConstructor();
$params = $constructor->getParameters();
$this->assertCount(2, $params);
$this->assertEquals('Domain\Newsletter\NewsletterRepository', $params[0]->getType()->getName());
$this->assertEquals('Domain\Newsletter\NewsletterPreviewRenderer', $params[1]->getType()->getName());
}
}