ver. 0.294: Code review complete — 96/96 classes, 27 fixes across all layers
Full codebase review of autoload/ directory (96 classes, ~1144 methods). Fixes: null safety (query/find guards), redundant DI bypass, undefined variables, missing globals, and Imagick WebP mime type bug in Helpers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -58,7 +58,7 @@ class PagesController
|
||||
|
||||
public function menuEdit(): string
|
||||
{
|
||||
$menu = $this->repository->menuDetails((int)\Shared\Helpers\Helpers::get('id'));
|
||||
$menu = $this->repository->menuDetails((int)\Shared\Helpers\Helpers::get('id')) ?: [];
|
||||
|
||||
return \Shared\Tpl\Tpl::view('pages/menu-edit', [
|
||||
'form' => $this->buildMenuFormViewModel($menu),
|
||||
@@ -167,7 +167,7 @@ class PagesController
|
||||
|
||||
public function edit(): string
|
||||
{
|
||||
$page = $this->repository->pageDetails((int)\Shared\Helpers\Helpers::get('id'));
|
||||
$page = $this->repository->pageDetails((int)\Shared\Helpers\Helpers::get('id')) ?: [];
|
||||
$parentId = (int)\Shared\Helpers\Helpers::get('pid');
|
||||
$menuId = (int)\Shared\Helpers\Helpers::get('menu_id');
|
||||
$menus = $this->repository->menusList();
|
||||
|
||||
Reference in New Issue
Block a user