ver. 0.294: Code review complete — 96/96 classes, 27 fixes across all layers
Full codebase review of autoload/ directory (96 classes, ~1144 methods). Fixes: null safety (query/find guards), redundant DI bypass, undefined variables, missing globals, and Imagick WebP mime type bug in Helpers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -137,7 +137,7 @@ class ScontainersController
|
||||
|
||||
public function edit(): string
|
||||
{
|
||||
$container = $this->repository->find((int)\Shared\Helpers\Helpers::get('id'));
|
||||
$container = $this->repository->find((int)\Shared\Helpers\Helpers::get('id')) ?: [];
|
||||
$languages = $this->languagesRepository->languagesList();
|
||||
$validationErrors = $_SESSION['form_errors'][$this->formId()] ?? null;
|
||||
if ($validationErrors) {
|
||||
@@ -172,7 +172,7 @@ class ScontainersController
|
||||
exit;
|
||||
}
|
||||
|
||||
$container = $this->repository->find((int)\Shared\Helpers\Helpers::get('id'));
|
||||
$container = $this->repository->find((int)\Shared\Helpers\Helpers::get('id')) ?: [];
|
||||
$languages = $this->languagesRepository->languagesList();
|
||||
$form = $this->buildFormViewModel($container, $languages);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user