ver 0.262 - pages module refactor and admin UX fixes

tests/Unit/Domain/Pages/PagesRepositoryTest.php

@@ -0,0 +1,66 @@
+<?php
+namespace Tests\Unit\Domain\Pages;
+
+use Domain\Pages\PagesRepository;
+use PHPUnit\Framework\TestCase;
+
+class PagesRepositoryTest extends TestCase
+{
+    public function testMenusListReturnsArray(): void
+    {
+        $mockDb = $this->createMock(\medoo::class);
+
+        $mockDb->expects($this->once())
+            ->method('select')
+            ->with('pp_menus', '*', ['ORDER' => ['id' => 'ASC']])
+            ->willReturn([
+                ['id' => 1, 'name' => 'Main'],
+            ]);
+
+        $repository = new PagesRepository($mockDb);
+        $menus = $repository->menusList();
+
+        $this->assertCount(1, $menus);
+        $this->assertSame(1, (int)$menus[0]['id']);
+        $this->assertSame('Main', (string)$menus[0]['name']);
+    }
+
+    public function testMenuDeleteReturnsFalseWhenMenuHasPages(): void
+    {
+        $mockDb = $this->createMock(\medoo::class);
+
+        $mockDb->expects($this->once())
+            ->method('count')
+            ->with('pp_pages', ['menu_id' => 3])
+            ->willReturn(2);
+
+        $mockDb->expects($this->never())->method('delete');
+
+        $repository = new PagesRepository($mockDb);
+        $this->assertFalse($repository->menuDelete(3));
+    }
+
+    public function testGenerateSeoLinkAddsSuffixWhenBaseSlugExists(): void
+    {
+        $mockDb = $this->createMock(\medoo::class);
+
+        $mockDb->expects($this->exactly(4))
+            ->method('count')
+            ->willReturnOnConsecutiveCalls(1, 0, 0, 0);
+
+        $repository = new PagesRepository($mockDb);
+        $seoLink = $repository->generateSeoLink('test title', 0, 0, 0);
+
+        $this->assertSame('test title-1', $seoLink);
+    }
+
+    public function testPageUrlPreviewBuildsLanguagePrefixedUrlForNonDefaultLanguage(): void
+    {
+        $mockDb = $this->createMock(\medoo::class);
+        $repository = new PagesRepository($mockDb);
+
+        $url = $repository->pageUrlPreview(5, 'en', 'About us', 'about-us', 'pl');
+
+        $this->assertSame('/en/about-us', $url);
+    }
+}

tests/Unit/admin/Controllers/ArticlesControllerTest.php

@@ -6,12 +6,14 @@ use admin\Controllers\ArticlesController;
 use Domain\Article\ArticleRepository;
 use Domain\Languages\LanguagesRepository;
 use Domain\Layouts\LayoutsRepository;
+use Domain\Pages\PagesRepository;
 
 class ArticlesControllerTest extends TestCase
 {
     private $mockRepository;
     private $mockLanguagesRepository;
     private $mockLayoutsRepository;
+    private $mockPagesRepository;
     private $controller;
 
     protected function setUp(): void
@@ -19,10 +21,12 @@ class ArticlesControllerTest extends TestCase
         $this->mockRepository = $this->createMock(ArticleRepository::class);
         $this->mockLanguagesRepository = $this->createMock(LanguagesRepository::class);
         $this->mockLayoutsRepository = $this->createMock(LayoutsRepository::class);
+        $this->mockPagesRepository = $this->createMock(PagesRepository::class);
         $this->controller = new ArticlesController(
             $this->mockRepository,
             $this->mockLanguagesRepository,
-            $this->mockLayoutsRepository
+            $this->mockLayoutsRepository,
+            $this->mockPagesRepository
         );
     }
 
@@ -36,7 +40,8 @@ class ArticlesControllerTest extends TestCase
         $controller = new ArticlesController(
             $this->mockRepository,
             $this->mockLanguagesRepository,
-            $this->mockLayoutsRepository
+            $this->mockLayoutsRepository,
+            $this->mockPagesRepository
         );
         $this->assertInstanceOf(ArticlesController::class, $controller);
     }
@@ -124,9 +129,10 @@ class ArticlesControllerTest extends TestCase
         $constructor = $reflection->getConstructor();
         $params = $constructor->getParameters();
 
-        $this->assertCount(3, $params);
+        $this->assertCount(4, $params);
         $this->assertEquals('Domain\Article\ArticleRepository', $params[0]->getType()->getName());
         $this->assertEquals('Domain\Languages\LanguagesRepository', $params[1]->getType()->getName());
         $this->assertEquals('Domain\Layouts\LayoutsRepository', $params[2]->getType()->getName());
+        $this->assertEquals('Domain\Pages\PagesRepository', $params[3]->getType()->getName());
     }
 }

tests/Unit/admin/Controllers/PagesControllerTest.php

@@ -0,0 +1,82 @@
+<?php
+namespace Tests\Unit\admin\Controllers;
+
+use admin\Controllers\PagesController;
+use Domain\Languages\LanguagesRepository;
+use Domain\Layouts\LayoutsRepository;
+use Domain\Pages\PagesRepository;
+use PHPUnit\Framework\TestCase;
+
+class PagesControllerTest extends TestCase
+{
+    private $mockRepository;
+    private $mockLanguagesRepository;
+    private $mockLayoutsRepository;
+    private $controller;
+
+    protected function setUp(): void
+    {
+        $this->mockRepository = $this->createMock(PagesRepository::class);
+        $this->mockLanguagesRepository = $this->createMock(LanguagesRepository::class);
+        $this->mockLayoutsRepository = $this->createMock(LayoutsRepository::class);
+
+        $this->controller = new PagesController(
+            $this->mockRepository,
+            $this->mockLanguagesRepository,
+            $this->mockLayoutsRepository
+        );
+    }
+
+    public function testConstructorAcceptsRepositories(): void
+    {
+        $controller = new PagesController(
+            $this->mockRepository,
+            $this->mockLanguagesRepository,
+            $this->mockLayoutsRepository
+        );
+
+        $this->assertInstanceOf(PagesController::class, $controller);
+    }
+
+    public function testHasMainActionMethods(): void
+    {
+        $this->assertTrue(method_exists($this->controller, 'list'));
+        $this->assertTrue(method_exists($this->controller, 'edit'));
+        $this->assertTrue(method_exists($this->controller, 'save'));
+        $this->assertTrue(method_exists($this->controller, 'delete'));
+        $this->assertTrue(method_exists($this->controller, 'menuEdit'));
+        $this->assertTrue(method_exists($this->controller, 'menuSave'));
+        $this->assertTrue(method_exists($this->controller, 'menuDelete'));
+        $this->assertTrue(method_exists($this->controller, 'savePagesOrder'));
+        $this->assertTrue(method_exists($this->controller, 'saveArticlesOrder'));
+        $this->assertTrue(method_exists($this->controller, 'generateSeoLink'));
+    }
+
+    public function testActionMethodReturnTypes(): void
+    {
+        $reflection = new \ReflectionClass($this->controller);
+
+        $this->assertEquals('string', (string)$reflection->getMethod('list')->getReturnType());
+        $this->assertEquals('string', (string)$reflection->getMethod('edit')->getReturnType());
+        $this->assertEquals('void', (string)$reflection->getMethod('save')->getReturnType());
+        $this->assertEquals('void', (string)$reflection->getMethod('delete')->getReturnType());
+        $this->assertEquals('string', (string)$reflection->getMethod('menuEdit')->getReturnType());
+        $this->assertEquals('void', (string)$reflection->getMethod('menuSave')->getReturnType());
+        $this->assertEquals('void', (string)$reflection->getMethod('menuDelete')->getReturnType());
+        $this->assertEquals('void', (string)$reflection->getMethod('savePagesOrder')->getReturnType());
+        $this->assertEquals('void', (string)$reflection->getMethod('saveArticlesOrder')->getReturnType());
+        $this->assertEquals('void', (string)$reflection->getMethod('generateSeoLink')->getReturnType());
+    }
+
+    public function testConstructorRequiresPagesLanguagesAndLayoutsRepositories(): void
+    {
+        $reflection = new \ReflectionClass(PagesController::class);
+        $constructor = $reflection->getConstructor();
+        $params = $constructor->getParameters();
+
+        $this->assertCount(3, $params);
+        $this->assertEquals('Domain\Pages\PagesRepository', $params[0]->getType()->getName());
+        $this->assertEquals('Domain\Languages\LanguagesRepository', $params[1]->getType()->getName());
+        $this->assertEquals('Domain\Layouts\LayoutsRepository', $params[2]->getType()->getName());
+    }
+}