Project-Pro/shopPRO
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ver. 0.294: Code review complete — 96/96 classes, 27 fixes across all layers

Browse Source 
Full codebase review of autoload/ directory (96 classes, ~1144 methods).
Fixes: null safety (query/find guards), redundant DI bypass, undefined
variables, missing globals, and Imagick WebP mime type bug in Helpers.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Jacek Pyziak
2026-02-19 15:26:07 +01:00
parent 0252ccea30
commit de11afb003
30 changed files with 1380 additions and 1164 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
autoload/Shared/Helpers/Helpers.php
View File

@@ -114,8 +114,8 @@ class Helpers
$img_src = implode( '/', $file_tmp );
$crop_w = $_GET['c_w'];
$crop_h = $_GET['c_h'];
$crop_w = $_GET['c_w'] ?? null;
$crop_h = $_GET['c_h'] ?? null;
$img_md5 = md5( $img_src . $height . $width . $crop_h . $crop_w );
$file = 'thumbs/' . $img_md5[0] . '/' . $img_md5[1] . '/' . $img_md5[2] . '/' . $img_md5;
@@ -174,7 +174,7 @@ class Helpers
$image = new \Imagick();
$image->readImage($file);
if ($file_type === 'png')
if ($file_type === 'image/png')
{
$image->setImageFormat('webp');
$image->setImageCompressionQuality($compression_quality);