update
This commit is contained in:
@@ -35,3 +35,21 @@ Goal: Add an administrator "Ustawienia formularza" page for editable registratio
|
||||
Planned:
|
||||
- `03-01`: Complete - created settings helper, admin page, deployment seed, and connected public form pricing/day options to editable settings.
|
||||
- `03-02`: Complete - added "Dodatkowe informacje" textarea field to form/DB/confirmations/admin; reversed admin Reg table order; codebase mapped.
|
||||
|
||||
---
|
||||
|
||||
## Milestone v0.2: Post-Launch Form Fixes
|
||||
|
||||
Status: ✅ Complete
|
||||
Completed: 2026-04-28
|
||||
|
||||
Progress: 1 of 1 phases complete (100%)
|
||||
|
||||
### Phase 4: Post-Launch Fixes
|
||||
Status: ✅ Complete
|
||||
Completed: 2026-04-28
|
||||
|
||||
Goal: Remove obsolete FAX field from the public form and admin views; hide room/person surcharge checkboxes when "one day without accommodation" is selected.
|
||||
|
||||
Planned:
|
||||
- `04-01`: Complete - removed FAX field from form and admin; surcharge block hides on one-day-no-lodging; FrontController PHP 7.2 count() fix.
|
||||
|
||||
@@ -1,27 +1,27 @@
|
||||
## Current Position
|
||||
|
||||
Milestone: v0.1 XXXV Konferencja Registration Update — ✅ COMPLETE
|
||||
Phase: 3 of 3 (Registration Form Settings) — ✅ Complete
|
||||
Plan: All plans unified
|
||||
Milestone: v0.2 Post-Launch Form Fixes — ✅ COMPLETE
|
||||
Phase: 4 of 4 (Post-Launch Fixes) — ✅ Complete
|
||||
Plan: 04-01 unified
|
||||
Status: Milestone complete — ready for next milestone
|
||||
Last activity: 2026-04-27 — Phase 3 transition complete; milestone v0.1 closed
|
||||
Last activity: 2026-04-28 — Phase 4 complete; milestone v0.2 closed
|
||||
|
||||
Progress:
|
||||
- Milestone: [##########] 100%
|
||||
- Phase 3: [##########] 100%
|
||||
- Phase 4: [##########] 100%
|
||||
|
||||
## Loop Position
|
||||
|
||||
Current loop state:
|
||||
```text
|
||||
PLAN ──▶ APPLY ──▶ UNIFY
|
||||
✓ ✓ ✓ [Milestone v0.1 complete]
|
||||
✓ ✓ ✓ [Milestone v0.2 complete]
|
||||
```
|
||||
|
||||
## Session Continuity
|
||||
|
||||
Last session: 2026-04-27
|
||||
Stopped at: Milestone v0.1 complete — all 3 phases, 4 plans unified
|
||||
Last session: 2026-04-28
|
||||
Stopped at: Milestone v0.2 complete — Phase 4, Plan 01 unified
|
||||
Next action: /paul:milestone to define next milestone, or /paul:discuss-milestone to explore options
|
||||
Resume file: .paul/ROADMAP.md
|
||||
|
||||
@@ -33,6 +33,7 @@ Resume file: .paul/ROADMAP.md
|
||||
| 2026-04-24: Use stable `registration_*` dictionary keys for registration-specific phrases | Phase 2 | Admin can edit visible registration wording without template changes. |
|
||||
| 2026-04-24: Preserve form values, persistence, pricing logic, and payment status values during dictionary refactor | Phase 2 | Registration behavior remains aligned with Phase 1. |
|
||||
| 2026-04-24: Plan form settings around `wp_setup` for new scalar/list settings and `mf_parameters` for existing price rows | Phase 3 | Avoids schema changes while exposing current calculation values in one admin screen. |
|
||||
| 2026-04-28: Keep FAX in DB/model, remove only from templates | Phase 4 | Existing records preserved; no schema migration needed. |
|
||||
|
||||
### Blockers/Concerns
|
||||
- Production must run `_rejestracja/sql/apply-2026-04-24-registration-dictionary-phrases.php?run=20260424` before dictionary entries are visible/editable.
|
||||
|
||||
16
.paul/changelog/2026-04-28.md
Normal file
16
.paul/changelog/2026-04-28.md
Normal file
@@ -0,0 +1,16 @@
|
||||
# 2026-04-28
|
||||
|
||||
## Co zrobiono
|
||||
|
||||
- [Phase 4, Plan 01] Post-launch fixes: usunięcie pola FAX i ukrywanie dopłat przy udziale jednodziowym
|
||||
- Usunięto pole "Fax" z formularza rejestracji publicznej (Index.tpl)
|
||||
- Usunięto wyświetlanie Fax z widoków administratora (Reg.tpl, RegEdit.tpl)
|
||||
- Zaktualizowano funkcję JS showSelectDate(): blok dopłat (#conference_1) jest teraz domyślnie ukrywany przy każdej zmianie opcji; przy wyborze "jeden dzień bez noclegu" checkboxy dopłat są odznaczane
|
||||
- Naprawiono pre-existingowy błąd PHP 7.2: count(null) w FrontController::GenerateTitle() — czerwony error na każdej stronie
|
||||
|
||||
## Zmienione pliki
|
||||
|
||||
- `_rejestracja/template/partial/Index/Index.tpl`
|
||||
- `_rejestracja/Admin/template/partial/Calc/Reg.tpl`
|
||||
- `_rejestracja/Admin/template/partial/Calc/RegEdit.tpl`
|
||||
- `_rejestracja/core/class/FrontController.class.php`
|
||||
10
.paul/governance/governance_2026-04-28.jsonl
Normal file
10
.paul/governance/governance_2026-04-28.jsonl
Normal file
@@ -0,0 +1,10 @@
|
||||
{"ts":"2026-04-28T13:33:56Z","tool":"Bash","cmd":"mkdir -p \"C:/visual studio code/projekty/aktualia.com.pl/.paul/phases/04-post-launch-fixes\"\",\"description\":\"Create phase 04 directory\"},\"tool_response\":{\"stdout\":\"\",\"stderr\":\"\",\"inte","cwd":"/c/visual studio code/projekty/aktualia.com.pl"}
|
||||
{"ts":"2026-04-28T13:34:37Z","tool":"Write","file":"C:\\\\visual studio code\\\\projekty\\\\aktualia.com.pl\\\\.paul\\\\phases\\\\04-post-launch-fixes\\\\04-01-PLAN.md","cwd":"/c/visual studio code/projekty/aktualia.com.pl"}
|
||||
{"ts":"2026-04-28T13:35:37Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\aktualia.com.pl\\\\_rejestracja\\\\template\\\\partial\\\\Index\\\\Index.tpl","cwd":"/c/visual studio code/projekty/aktualia.com.pl"}
|
||||
{"ts":"2026-04-28T13:35:38Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\aktualia.com.pl\\\\_rejestracja\\\\Admin\\\\template\\\\partial\\\\Calc\\\\Reg.tpl","cwd":"/c/visual studio code/projekty/aktualia.com.pl"}
|
||||
{"ts":"2026-04-28T13:35:39Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\aktualia.com.pl\\\\_rejestracja\\\\Admin\\\\template\\\\partial\\\\Calc\\\\RegEdit.tpl","cwd":"/c/visual studio code/projekty/aktualia.com.pl"}
|
||||
{"ts":"2026-04-28T13:36:06Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\aktualia.com.pl\\\\_rejestracja\\\\template\\\\partial\\\\Index\\\\Index.tpl","cwd":"/c/visual studio code/projekty/aktualia.com.pl"}
|
||||
{"ts":"2026-04-28T13:39:24Z","tool":"Edit","file":"C:\\\\visual studio code\\\\projekty\\\\aktualia.com.pl\\\\_rejestracja\\\\core\\\\class\\\\FrontController.class.php","cwd":"/c/visual studio code/projekty/aktualia.com.pl"}
|
||||
{"ts":"2026-04-28T13:41:00Z","tool":"Write","file":"C:\\\\visual studio code\\\\projekty\\\\aktualia.com.pl\\\\.paul\\\\phases\\\\04-post-launch-fixes\\\\04-01-SUMMARY.md","cwd":"/c/visual studio code/projekty/aktualia.com.pl"}
|
||||
{"ts":"2026-04-28T13:41:06Z","tool":"Bash","cmd":"mkdir -p \"C:/visual studio code/projekty/aktualia.com.pl/.paul/changelog\"\",\"description\":\"Ensure changelog directory exists\"},\"tool_response\":{\"stdout\":\"\",\"stderr\":\"\",\"interrupted\":","cwd":"/c/visual studio code/projekty/aktualia.com.pl"}
|
||||
{"ts":"2026-04-28T13:41:15Z","tool":"Write","file":"C:\\\\visual studio code\\\\projekty\\\\aktualia.com.pl\\\\.paul\\\\changelog\\\\2026-04-28.md","cwd":"/c/visual studio code/projekty/aktualia.com.pl"}
|
||||
191
.paul/phases/04-post-launch-fixes/04-01-PLAN.md
Normal file
191
.paul/phases/04-post-launch-fixes/04-01-PLAN.md
Normal file
@@ -0,0 +1,191 @@
|
||||
---
|
||||
phase: 04-post-launch-fixes
|
||||
plan: 01
|
||||
type: execute
|
||||
wave: 1
|
||||
depends_on: []
|
||||
files_modified:
|
||||
- _rejestracja/template/partial/Index/Index.tpl
|
||||
- _rejestracja/Admin/template/partial/Calc/Reg.tpl
|
||||
- _rejestracja/Admin/template/partial/Calc/RegEdit.tpl
|
||||
autonomous: true
|
||||
delegation: off
|
||||
---
|
||||
|
||||
<objective>
|
||||
## Goal
|
||||
Remove the obsolete FAX field from the public registration form and admin views, and hide the "single room surcharge" and "accompanying person" checkboxes when "one day without accommodation" participation option is selected.
|
||||
|
||||
## Purpose
|
||||
Two small UX fixes requested by the client post-launch: FAX is obsolete and clutters the form; the room/person surcharges are irrelevant for one-day-no-lodging participation so they should be hidden to avoid confusion.
|
||||
|
||||
## Output
|
||||
- FAX field removed from public form template and admin participant display templates
|
||||
- JS `showSelectDate()` updated to hide/show `#conference_1` surcharge block based on participation option
|
||||
</objective>
|
||||
|
||||
<context>
|
||||
## Project Context
|
||||
@.paul/PROJECT.md
|
||||
@.paul/ROADMAP.md
|
||||
@.paul/STATE.md
|
||||
|
||||
## Source Files
|
||||
@_rejestracja/template/partial/Index/Index.tpl
|
||||
@_rejestracja/Admin/template/partial/Calc/Reg.tpl
|
||||
@_rejestracja/Admin/template/partial/Calc/RegEdit.tpl
|
||||
</context>
|
||||
|
||||
<acceptance_criteria>
|
||||
|
||||
## AC-1: FAX field removed from public form
|
||||
```gherkin
|
||||
Given the public registration form at /_rejestracja/
|
||||
When a user views the form
|
||||
Then there is no "Fax" label or input field visible
|
||||
```
|
||||
|
||||
## AC-2: FAX removed from admin views
|
||||
```gherkin
|
||||
Given the admin participant list (Reg.tpl) and edit view (RegEdit.tpl)
|
||||
When an admin views participant details
|
||||
Then there is no "Fax:" line in the participant contact data
|
||||
```
|
||||
|
||||
## AC-3: Surcharge fields hidden for one-day-no-lodging
|
||||
```gherkin
|
||||
Given the public registration form
|
||||
When the user selects "udział jeden dzień bez noclegu" (conference_fee_1, value=5)
|
||||
Then the #conference_1 block (containing "dopłata do pokoju 1-osobowego" and "udział osoby towarzyszącej") is hidden and its checkboxes are unchecked
|
||||
```
|
||||
|
||||
## AC-4: Surcharge fields shown for full conference
|
||||
```gherkin
|
||||
Given the public registration form
|
||||
When the user selects the full conference option (conference_fee, value=1)
|
||||
Then the #conference_1 block is visible
|
||||
```
|
||||
|
||||
</acceptance_criteria>
|
||||
|
||||
<tasks>
|
||||
|
||||
<task type="auto">
|
||||
<name>Task 1: Remove FAX field from public form and admin views</name>
|
||||
<files>
|
||||
_rejestracja/template/partial/Index/Index.tpl,
|
||||
_rejestracja/Admin/template/partial/Calc/Reg.tpl,
|
||||
_rejestracja/Admin/template/partial/Calc/RegEdit.tpl
|
||||
</files>
|
||||
<action>
|
||||
In `_rejestracja/template/partial/Index/Index.tpl`:
|
||||
- Remove the entire `<div class="entry">` block containing the "Fax" label and `{formField name="fax" ...}` (currently lines 45–48).
|
||||
|
||||
In `_rejestracja/Admin/template/partial/Calc/Reg.tpl`:
|
||||
- Remove the line `Fax: {$obj->getFax()}</br>` from the participant contact cell (currently line 49).
|
||||
|
||||
In `_rejestracja/Admin/template/partial/Calc/RegEdit.tpl`:
|
||||
- Remove the line `Fax: {$objParticipant->getFax()|default:$registrationMissing}</br>` from the edit view (currently line 36).
|
||||
|
||||
Do NOT modify the PHP model, controller, or database schema — the `fax` column stays in DB for existing records.
|
||||
</action>
|
||||
<verify>
|
||||
Visually inspect the public form — no "Fax" row present.
|
||||
Grep: `grep -n "fax\|Fax" _rejestracja/template/partial/Index/Index.tpl _rejestracja/Admin/template/partial/Calc/Reg.tpl _rejestracja/Admin/template/partial/Calc/RegEdit.tpl`
|
||||
Expected: no matches in the three template files.
|
||||
</verify>
|
||||
<done>AC-1 and AC-2 satisfied: FAX absent from public form and both admin templates.</done>
|
||||
</task>
|
||||
|
||||
<task type="auto">
|
||||
<name>Task 2: Hide surcharge checkboxes when one-day-no-lodging is selected</name>
|
||||
<files>_rejestracja/template/partial/Index/Index.tpl</files>
|
||||
<action>
|
||||
In the `showSelectDate()` JavaScript function (inside the `{literal}...{/literal}` block in Index.tpl), update the logic as follows:
|
||||
|
||||
Current behaviour:
|
||||
- Full conference radio (`conference_fee`, onclick): calls `$('#conference_1').show()` explicitly in its `onclick` attribute.
|
||||
- One-day-no-lodging radio (`conference_fee_1`, onclick): only calls `calculatePrice()`.
|
||||
- `showSelectDate()` does not touch `#conference_1`.
|
||||
|
||||
Required change — inside `showSelectDate()`, add visibility toggling for `#conference_1`:
|
||||
1. At the start of `showSelectDate()`, after the existing hide/reset lines, add: `$('#conference_1').hide();` (default to hidden when option changes).
|
||||
2. In the `if (selectedId === 'conference_fee')` branch (full conference — note: there is no such branch yet, add it): show `#conference_1`.
|
||||
Actually the full conference radio id is `conference_fee` (the radio with `checked="true"` and value=1). Add the branch:
|
||||
```
|
||||
if (selectedId === 'conference_fee') {
|
||||
$('#conference_1').show();
|
||||
}
|
||||
```
|
||||
3. In the `if (selectedId === 'conference_fee_1')` branch (one day no lodging): already handled by the default hide above, but also uncheck both checkboxes:
|
||||
```
|
||||
if (selectedId === 'conference_fee_1') {
|
||||
$('#participation_option').val('one_day_no_lodging');
|
||||
$('#one-day-no-lodging-days').css('display', 'flex');
|
||||
$('#price_plus_room').prop('checked', false);
|
||||
$('#price_plus_person').prop('checked', false);
|
||||
}
|
||||
```
|
||||
|
||||
Also remove the inline `onclick="$('#conference_1').show(); $('#conference_2').hide(); calculatePrice();"` from the full conference radio input and replace it with just `onclick="showSelectDate(); calculatePrice();"` — or simply add `showSelectDate()` logic to handle it, keeping existing calculatePrice() calls.
|
||||
|
||||
Simpler approach to minimise risk: Keep the inline onclick on the full conference radio as-is (`$('#conference_1').show(); ...`) and only modify `showSelectDate()` to:
|
||||
- After the three existing hide/reset lines (lines ~218-222), add: `$('#conference_1').hide();`
|
||||
- In the `if (selectedId === 'conference_fee_1')` block, add unchecking of the two checkboxes:
|
||||
```js
|
||||
$('#price_plus_room').prop('checked', false);
|
||||
$('#price_plus_person').prop('checked', false);
|
||||
```
|
||||
This way, when `showSelectDate()` fires on `conference_fee_1` change, `#conference_1` is hidden and checkboxes are cleared. When the full conference radio fires its inline onclick, it explicitly calls `$('#conference_1').show()` before `calculatePrice()` — unchanged behaviour.
|
||||
|
||||
Avoid: touching calculatePrice() logic or any server-side code.
|
||||
</action>
|
||||
<verify>
|
||||
Manual test flow:
|
||||
1. Load the registration form.
|
||||
2. Select "udział jeden dzień bez noclegu" — confirm #conference_1 block disappears and both checkboxes are unchecked.
|
||||
3. Re-select full conference — confirm #conference_1 block reappears.
|
||||
4. Verify price calculation still works correctly for both options.
|
||||
</verify>
|
||||
<done>AC-3 and AC-4 satisfied: surcharge block hidden on one-day-no-lodging, visible on full conference.</done>
|
||||
</task>
|
||||
|
||||
</tasks>
|
||||
|
||||
<boundaries>
|
||||
|
||||
## DO NOT CHANGE
|
||||
- `_rejestracja/controller/IndexController.php` — FAX is still saved from POST (will just be empty); no controller changes needed.
|
||||
- `_rejestracja/core/model/MfParticipant.class.php` — DB model unchanged.
|
||||
- Any database schema or migration files.
|
||||
- Pricing calculation logic (`calculatePrice()` function body).
|
||||
- Any other form fields or admin templates not listed above.
|
||||
|
||||
## SCOPE LIMITS
|
||||
- Do not remove FAX from the DB column or PHP model.
|
||||
- Do not change the admin edit form inputs for FAX (RegEdit.tpl input field, if any) — only remove the display line; if there's an editable FAX input in RegEdit.tpl, remove that display label only, not the save logic.
|
||||
- Do not redesign or refactor the showSelectDate() function beyond the targeted change.
|
||||
|
||||
</boundaries>
|
||||
|
||||
<verification>
|
||||
Before declaring plan complete:
|
||||
- [ ] `grep -n "Fax\|fax" _rejestracja/template/partial/Index/Index.tpl` returns no results (or only comments/model)
|
||||
- [ ] `grep -n "Fax" _rejestracja/Admin/template/partial/Calc/Reg.tpl` returns no results
|
||||
- [ ] `grep -n "Fax" _rejestracja/Admin/template/partial/Calc/RegEdit.tpl` returns no results
|
||||
- [ ] Public form loads without PHP errors
|
||||
- [ ] Selecting one-day-no-lodging hides #conference_1 surcharges
|
||||
- [ ] Selecting full conference shows #conference_1 surcharges
|
||||
- [ ] Price calculation works correctly for all options
|
||||
</verification>
|
||||
|
||||
<success_criteria>
|
||||
- All tasks completed
|
||||
- FAX field absent from public form and both admin templates
|
||||
- Surcharge block toggles correctly with participation option selection
|
||||
- No regressions in pricing, form submission, or admin display
|
||||
</success_criteria>
|
||||
|
||||
<output>
|
||||
After completion, create `.paul/phases/04-post-launch-fixes/04-01-SUMMARY.md`
|
||||
</output>
|
||||
108
.paul/phases/04-post-launch-fixes/04-01-SUMMARY.md
Normal file
108
.paul/phases/04-post-launch-fixes/04-01-SUMMARY.md
Normal file
@@ -0,0 +1,108 @@
|
||||
---
|
||||
phase: 04-post-launch-fixes
|
||||
plan: 01
|
||||
subsystem: ui
|
||||
tags: [php, smarty, javascript, form]
|
||||
|
||||
requires: []
|
||||
provides:
|
||||
- FAX field removed from public registration form and admin participant views
|
||||
- Surcharge checkboxes hidden when one-day-no-lodging option selected
|
||||
- PHP 7.2 count() warning fixed in FrontController
|
||||
|
||||
key-files:
|
||||
modified:
|
||||
- _rejestracja/template/partial/Index/Index.tpl
|
||||
- _rejestracja/Admin/template/partial/Calc/Reg.tpl
|
||||
- _rejestracja/Admin/template/partial/Calc/RegEdit.tpl
|
||||
- _rejestracja/core/class/FrontController.class.php
|
||||
|
||||
key-decisions:
|
||||
- "FAX kept in DB/model — only removed from templates; existing records preserved"
|
||||
- "showSelectDate() default-hides #conference_1; full-conference inline onclick restores it"
|
||||
|
||||
duration: ~15min
|
||||
completed: 2026-04-28T00:00:00Z
|
||||
---
|
||||
|
||||
# Phase 4 Plan 01: Post-Launch Fixes Summary
|
||||
|
||||
**FAX field removed from form and admin views; surcharge block now hidden when one-day-no-lodging is selected; PHP 7.2 count() warning fixed.**
|
||||
|
||||
## Performance
|
||||
|
||||
| Metric | Value |
|
||||
|--------|-------|
|
||||
| Duration | ~15 min |
|
||||
| Completed | 2026-04-28 |
|
||||
| Tasks | 2 completed |
|
||||
| Files modified | 4 |
|
||||
|
||||
## Acceptance Criteria Results
|
||||
|
||||
| Criterion | Status | Notes |
|
||||
|-----------|--------|-------|
|
||||
| AC-1: FAX removed from public form | Pass | Div block with label + formField removed from Index.tpl |
|
||||
| AC-2: FAX removed from admin views | Pass | Line removed from Reg.tpl and RegEdit.tpl |
|
||||
| AC-3: Surcharges hidden on one-day-no-lodging | Pass | showSelectDate() hides #conference_1 by default; conference_fee_1 branch unchecks both checkboxes |
|
||||
| AC-4: Surcharges shown on full conference | Pass | Full conference radio inline onclick still calls `$('#conference_1').show()` |
|
||||
|
||||
## Accomplishments
|
||||
|
||||
- Removed obsolete FAX field from public form (Index.tpl) — no longer collected or displayed to registrants
|
||||
- Removed FAX display line from both admin participant views (Reg.tpl, RegEdit.tpl)
|
||||
- Updated `showSelectDate()` JS: adds `$('#conference_1').hide()` as default reset, plus unchecks `#price_plus_room` and `#price_plus_person` when one-day-no-lodging is selected
|
||||
- Fixed pre-existing PHP 7.2 compatibility warning in `FrontController::GenerateTitle()` — `count(null)` replaced with safe array cast
|
||||
|
||||
## Files Created/Modified
|
||||
|
||||
| File | Change | Purpose |
|
||||
|------|--------|---------|
|
||||
| `_rejestracja/template/partial/Index/Index.tpl` | Modified | Removed FAX field div; updated showSelectDate() JS |
|
||||
| `_rejestracja/Admin/template/partial/Calc/Reg.tpl` | Modified | Removed Fax display line from participant list |
|
||||
| `_rejestracja/Admin/template/partial/Calc/RegEdit.tpl` | Modified | Removed Fax display line from participant edit view |
|
||||
| `_rejestracja/core/class/FrontController.class.php` | Modified | Fixed count(null) PHP 7.2 warning in GenerateTitle() |
|
||||
|
||||
## Decisions Made
|
||||
|
||||
| Decision | Rationale | Impact |
|
||||
|----------|-----------|--------|
|
||||
| Keep FAX in DB/model, remove only from templates | Preserves existing records; no migration needed | Historical FAX data remains accessible via DB direct query |
|
||||
| Default-hide #conference_1 in showSelectDate(), keep inline .show() on full-conference radio | Minimal change — avoids refactoring working onclick; showSelectDate fires on change only | Clean toggle behaviour with fewest lines changed |
|
||||
|
||||
## Deviations from Plan
|
||||
|
||||
### Summary
|
||||
|
||||
| Type | Count | Impact |
|
||||
|------|-------|--------|
|
||||
| Auto-fixed | 1 | PHP 7.2 warning eliminated |
|
||||
| Scope additions | 0 | — |
|
||||
| Deferred | 0 | — |
|
||||
|
||||
**Total impact:** One opportunistic fix outside plan scope — essential (was causing visible red error on every page load).
|
||||
|
||||
### Auto-fixed Issues
|
||||
|
||||
**1. PHP 7.2 `count()` warning in FrontController**
|
||||
- **Found during:** User reported red error immediately after APPLY
|
||||
- **Issue:** `FrontController::GenerateTitle()` called `count($headers['title'])` where `$headers['title']` can be `null`; PHP 7.2+ raises E_WARNING
|
||||
- **Fix:** `$t = isset($headers['title']) && is_array($headers['title']) ? $headers['title'] : [];`
|
||||
- **Files:** `_rejestracja/core/class/FrontController.class.php:358`
|
||||
- **Verification:** Error no longer appears on page load
|
||||
|
||||
## Next Phase Readiness
|
||||
|
||||
**Ready:**
|
||||
- Milestone v0.2 complete — both client requests implemented
|
||||
- No open deferred issues
|
||||
|
||||
**Concerns:**
|
||||
- None
|
||||
|
||||
**Blockers:**
|
||||
- None
|
||||
|
||||
---
|
||||
*Phase: 04-post-launch-fixes, Plan: 01*
|
||||
*Completed: 2026-04-28*
|
||||
4
.vscode/ftp-kr.sync.cache.json
vendored
4
.vscode/ftp-kr.sync.cache.json
vendored
@@ -1102,8 +1102,8 @@
|
||||
},
|
||||
"Index.tpl": {
|
||||
"type": "-",
|
||||
"size": 29256,
|
||||
"lmtime": 1777296501335,
|
||||
"size": 28666,
|
||||
"lmtime": 1777368403260,
|
||||
"modified": false
|
||||
},
|
||||
"Index.tpl.bak": {
|
||||
|
||||
@@ -46,7 +46,6 @@
|
||||
<td>Tytuł/stop. naukowy:{$obj->getDegree()}</br>
|
||||
Stanowisko: {$obj->getPosition()}</br>
|
||||
Telefon: {$obj->getPhone()}</br>
|
||||
Fax: {$obj->getFax()}</br>
|
||||
Email: {$obj->getEmail()}</br></td>
|
||||
<td >Instytucja: {$obj->getInstitution()}</br>
|
||||
Ulica i numer: {$obj->getAddress()}</br>
|
||||
|
||||
@@ -33,7 +33,6 @@ urlStatic = '{$urlStatic}';
|
||||
Tytuł/stop. naukowy:{$objParticipant->getDegree()}</br>
|
||||
Stanowisko: {$objParticipant->getPosition()|default:$registrationMissing}</br>
|
||||
Telefon: {$objParticipant->getPhone()}</br>
|
||||
Fax: {$objParticipant->getFax()|default:$registrationMissing}</br>
|
||||
Email: {$objParticipant->getEmail()}</br>
|
||||
</td>
|
||||
</tr>
|
||||
|
||||
@@ -355,7 +355,7 @@ class FrontController {
|
||||
private function GenerateTitle() {
|
||||
$headers = Registry::Get('headers');
|
||||
//Utils::ArrayDisplay($headers);
|
||||
$t = $headers['title'];
|
||||
$t = isset($headers['title']) && is_array($headers['title']) ? $headers['title'] : [];
|
||||
if(count($t)>1) {
|
||||
$title = implode($this->titleDelimiter, $t);
|
||||
} else if (count($t) == 1) {
|
||||
|
||||
@@ -42,10 +42,6 @@
|
||||
<div class="label">{translate word='Telefon'}:</div>
|
||||
<div class="value">{formField name="phone" type="text" errorClass="warning"}</div>
|
||||
</div>
|
||||
<div class="entry">
|
||||
<div class="label">{translate word='Fax'}:</div>
|
||||
<div class="value">{formField name="fax" type="text" errorClass="warning"}</div>
|
||||
</div>
|
||||
<div class="entry">
|
||||
<div class="label">{translate word='email'}:</div>
|
||||
<div class="value">{formField name="email" type="text" errorClass="warning"}</div>
|
||||
@@ -220,6 +216,7 @@
|
||||
$('#participation_option').val('full');
|
||||
$('#one-day-lodging-days').hide();
|
||||
$('#one-day-no-lodging-days').hide();
|
||||
$('#conference_1').hide();
|
||||
|
||||
if (selectedId === 'conference_fee_1_lodging') {
|
||||
$('#participation_option').val('one_day_lodging');
|
||||
@@ -229,6 +226,8 @@
|
||||
if (selectedId === 'conference_fee_1') {
|
||||
$('#participation_option').val('one_day_no_lodging');
|
||||
$('#one-day-no-lodging-days').css('display', 'flex');
|
||||
$('#price_plus_room').prop('checked', false);
|
||||
$('#price_plus_person').prop('checked', false);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user