131 lines
5.2 KiB
Markdown
131 lines
5.2 KiB
Markdown
---
|
||
phase: 03-form-submit-booking
|
||
plan: 01
|
||
subsystem: ui, api
|
||
tags: [softra-api, booking, customer, pricing-summary, form, modal]
|
||
|
||
requires:
|
||
- phase: 02-form-ui-step1
|
||
provides: Form UI with segment/branch filtering, validation, data collection
|
||
provides:
|
||
- Complete booking flow: customer creation → pricing summary → reservation → confirmation
|
||
- Address and PESEL fields for API compliance
|
||
- Pricing summary overlay with cost breakdown
|
||
- Success view with reservation number
|
||
affects: [04-polish-testing, 05-admin-panel]
|
||
|
||
tech-stack:
|
||
added: []
|
||
patterns: [multi-step API flow with error recovery, boolean API params for Java backend]
|
||
|
||
key-files:
|
||
modified:
|
||
- wp-content/plugins/carei-reservation/includes/class-elementor-widget.php
|
||
- wp-content/plugins/carei-reservation/assets/css/carei-reservation.css
|
||
- wp-content/plugins/carei-reservation/assets/js/carei-reservation.js
|
||
- wp-content/plugins/carei-reservation/includes/class-softra-api.php
|
||
- wp-content/plugins/carei-reservation/includes/class-rest-proxy.php
|
||
|
||
key-decisions:
|
||
- "Boolean values for Java API (true/false not 'T'/'N') despite documentation saying otherwise"
|
||
- "Simplified segments-branches-map: 2 API calls instead of ~40 — all branches shown for all segments"
|
||
- "drivers[] required in makebooking — populated from form data (same person as customer)"
|
||
- "skipAccountCreate: true — no customer account, MVP approach"
|
||
- "Penalty items (BRAK, BRUD, KARA) filtered out from extras display"
|
||
|
||
patterns-established:
|
||
- "Softra API uses Java boolean deserialization — always send true/false, never 'T'/'N'"
|
||
- "Multi-step API flow with error recovery at each step"
|
||
|
||
duration: ~2h
|
||
started: 2026-03-25T11:00:00Z
|
||
completed: 2026-03-25T13:00:00Z
|
||
---
|
||
|
||
# Phase 3 Plan 01: Submit + Booking Flow Summary
|
||
|
||
**Pełny flow rezerwacji: formularz → tworzenie klienta → podsumowanie kosztów w overlay → złożenie rezerwacji → potwierdzenie z numerem.**
|
||
|
||
## Performance
|
||
|
||
| Metric | Value |
|
||
|--------|-------|
|
||
| Duration | ~2h |
|
||
| Tasks | 3 completed |
|
||
| Files modified | 5 |
|
||
|
||
## Acceptance Criteria Results
|
||
|
||
| Criterion | Status | Notes |
|
||
|-----------|--------|-------|
|
||
| AC-1: Dodatkowe pola (adres, PESEL) | Pass | Miejscowość, kod pocztowy, ulica, PESEL — wymagane, walidowane |
|
||
| AC-2: Submit tworzy klienta i pokazuje podsumowanie | Pass | customer/add → princingSummary → overlay z tabelą kosztów i wszystkimi wybranymi opcjami |
|
||
| AC-3: Potwierdzenie rezerwacji kończy flow | Pass | makebooking → confirm → success view z numerem rezerwacji |
|
||
|
||
## Accomplishments
|
||
|
||
- Pełny booking flow działa end-to-end na produkcji
|
||
- Overlay podsumowania pokazuje: dane wynajmu, najemcę, wybrane opcje, tabelę kosztów (netto/VAT/brutto)
|
||
- Error handling na każdym kroku z czytelnym komunikatem
|
||
- Endpoint /booking/cancel dodany (UI do wykorzystania w przyszłości)
|
||
|
||
## Files Modified
|
||
|
||
| File | Change | Purpose |
|
||
|------|--------|---------|
|
||
| `includes/class-elementor-widget.php` | Modified | Pola adresowe + PESEL, overlay podsumowania, success view |
|
||
| `assets/css/carei-reservation.css` | Modified | 800+ linii — style summary, success, address row |
|
||
| `assets/js/carei-reservation.js` | Modified | 730+ linii — pełny booking flow z error handling |
|
||
| `includes/class-softra-api.php` | Modified | cancel_booking(), uproszczone segments-branches-map (2 calls) |
|
||
| `includes/class-rest-proxy.php` | Modified | Endpoint POST /booking/cancel |
|
||
|
||
## Decisions Made
|
||
|
||
| Decision | Rationale | Impact |
|
||
|----------|-----------|--------|
|
||
| Boolean zamiast string w API | Java deserializacja nie akceptuje 'T'/'N', wymaga true/false | Wszystkie pola boolean muszą być native boolean |
|
||
| Uproszczone mapowanie segment→branch | 39 oddziałów × 30s timeout = niemożliwe w jednym request | Wszystkie oddziały dostępne dla każdego segmentu, API weryfikuje przy rezerwacji |
|
||
| drivers[] z danymi najemcy | API wymaga (NotNull), dokumentacja nie zaznacza jako required | Kierowca = ten sam co najemca formularza |
|
||
|
||
## Deviations from Plan
|
||
|
||
### Summary
|
||
|
||
| Type | Count | Impact |
|
||
|------|-------|--------|
|
||
| Auto-fixed | 3 | API compatibility fixes discovered during testing |
|
||
|
||
### Auto-fixed Issues
|
||
|
||
**1. Boolean serialization**
|
||
- Issue: isCompany='N', skipAccountCreate='T' → HTTP 400
|
||
- Fix: Changed to isCompany: false, skipAccountCreate: true
|
||
- Verification: customer/add returns 200 with customerId
|
||
|
||
**2. Segments-branches-map timeout**
|
||
- Issue: ~40 sequential API calls → cURL timeout after 30s
|
||
- Fix: Simplified to 2 API calls (branches + car-classes-all), all branches shown for all segments
|
||
- Verification: Endpoint returns in <2s
|
||
|
||
**3. Missing drivers field**
|
||
- Issue: makebooking requires drivers[] (NotNull), not documented as required
|
||
- Fix: Added drivers array with form data (firstName, lastName, address, pesel, phone, email)
|
||
- Verification: makebooking returns success with reservationId
|
||
|
||
## Next Phase Readiness
|
||
|
||
**Ready:**
|
||
- Rezerwacja działa end-to-end
|
||
- Wszystkie endpointy API przetestowane na produkcji
|
||
- Error handling na każdym kroku
|
||
|
||
**Concerns:**
|
||
- Penalty items z pricelist filtrowane po kodzie (BRAK/BRUD/KARA) — może nie pokryć wszystkich
|
||
- Brak email notification po rezerwacji (zależy od konfiguracji Softra)
|
||
|
||
**Blockers:** None
|
||
|
||
---
|
||
*Phase: 03-form-submit-booking, Plan: 01*
|
||
*Completed: 2026-03-25*
|