Fix: testy + bugfix SettingsRepository::allSettings() + migracja phpunit.xml

- SettingsRepository::allSettings() — inicjalizacja $settings = [] przed pętlą
  (bug: false ?? [] zwracało false gdy cache pusty a DB null)
- Stuby wydzielone do tests/stubs/CacheHandler.php + S.php
- phpunit.xml zmigurowany do schematu PHPUnit 10 (coverage → source)
- composer.lock dodany do repozytorium

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-02-27 23:56:00 +01:00
parent 8e6b29976c
commit 2e715e803e
7 changed files with 1741 additions and 56 deletions

View File

@@ -18,12 +18,13 @@ class SettingsRepository
{
if ( !$settings = \Shared\Cache\CacheHandler::fetch( 'settings_details' ) )
{
$results = $this->db->select( 'pp_settings', '*' );
$settings = [];
$results = $this->db->select( 'pp_settings', '*' );
if ( is_array( $results ) )
foreach ( $results as $row )
$settings[ $row['param'] ] = $row['value'];
\Shared\Cache\CacheHandler::store( 'settings_details', $settings ?? [] );
\Shared\Cache\CacheHandler::store( 'settings_details', $settings );
}
return $settings ?? [];

1688
composer.lock generated Normal file

File diff suppressed because it is too large Load Diff

View File

@@ -1,20 +1,14 @@
<?xml version="1.0" encoding="UTF-8"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
bootstrap="tests/bootstrap.php"
colors="true">
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd" bootstrap="tests/bootstrap.php" colors="true">
<testsuites>
<testsuite name="Unit">
<directory>tests/Unit</directory>
</testsuite>
</testsuites>
<coverage>
<source>
<include>
<directory>autoload/Domain</directory>
<directory>autoload/Shared</directory>
</include>
</coverage>
</source>
</phpunit>

View File

@@ -47,7 +47,7 @@ class SettingsRepositoryTest extends TestCase
$db = $this->mockDb();
$db->expects($this->never())->method('select');
\CacheHandlerStub::store('settings_details', ['cached' => '1']);
\Shared\Cache\CacheHandler::store('settings_details', ['cached' => '1']);
$repo = new SettingsRepository($db);
$result = $repo->allSettings();

View File

@@ -1,51 +1,21 @@
<?php
// Medoo ORM — potrzebny do mockowania w testach
// Medoo ORM
require_once __DIR__ . '/../libraries/medoo/medoo.php';
// Stub: \Shared\Cache\CacheHandler — musi być załadowany PRZED autoloaderem
// żeby nie nadpisała go prawdziwa klasa
namespace Shared\Cache {
class CacheHandler
{
private static array $store = [];
// Stuby — mus być załadowane PRZED autoloaderem PSR-4,
// żeby nie zostały nadpisane przez prawdziwe klasy
require_once __DIR__ . '/stubs/CacheHandler.php';
require_once __DIR__ . '/stubs/S.php';
public static function reset(): void { self::$store = []; }
public static function fetch(string $key): mixed
{
return self::$store[$key] ?? false;
}
public static function store(string $key, mixed $value, int $ttl = 0): void
{
self::$store[$key] = $value;
}
public static function delete(string $key): void
{
unset(self::$store[$key]);
// PSR-4 autoloader dla Domain\
// Shared\ jest obsłużona przez stub powyżej — pomijamy w autoloaderze
spl_autoload_register(function (string $class): void {
if (strncmp($class, 'Domain\\', 7) === 0) {
$rel = substr($class, 7);
$file = __DIR__ . '/../autoload/Domain/' . str_replace('\\', '/', $rel) . '.php';
if (file_exists($file)) {
require $file;
}
}
}
// Stub: \S — metody statyczne używane przez repozytoria
namespace {
class S
{
public static function delete_cache(): void {}
public static function htacces(): void {}
public static function get_domain(string $domain = ''): ?string { return $domain ?: null; }
public static function send_email(string $to, string $subject, string $body): bool { return true; }
}
// PSR-4 autoloader dla Domain\
// Shared\ jest już obsłużona przez stubę powyżej — pomijamy ją w autoloaderze
spl_autoload_register(function (string $class): void {
if (strncmp($class, 'Domain\\', 7) === 0) {
$rel = substr($class, 7);
$file = __DIR__ . '/../autoload/Domain/' . str_replace('\\', '/', $rel) . '.php';
if (file_exists($file)) { require $file; }
}
});
}
});

View File

@@ -0,0 +1,24 @@
<?php
namespace Shared\Cache;
class CacheHandler
{
private static array $store = [];
public static function reset(): void { self::$store = []; }
public static function fetch(string $key): mixed
{
return self::$store[$key] ?? false;
}
public static function store(string $key, mixed $value, int $ttl = 0): void
{
self::$store[$key] = $value;
}
public static function delete(string $key): void
{
unset(self::$store[$key]);
}
}

8
tests/stubs/S.php Normal file
View File

@@ -0,0 +1,8 @@
<?php
class S
{
public static function delete_cache(): void {}
public static function htacces(): void {}
public static function get_domain(string $domain = ''): ?string { return $domain ?: null; }
public static function send_email(string $to, string $subject, string $body): bool { return true; }
}