Files

Jacek Pyziak 2ab461aaae feat(125): invoice_requested import fix + drop legacy is_invoice column

- shopPRO: ShopproOrderMapper jako jedyne zrodlo heurystyki detekcji faktury;
  mapOrderAggregate() zwraca top-level invoice_detected (transient).
- ShopproOrdersSyncService: usunieta wlasna shouldRequestInvoice(); propagacja
  aggregate['invoice_detected'] do setInvoiceRequested() tylko przy created=true.
- Allegro: nowa shouldRequestInvoice(payload) z 4 wzorcami (invoice.required,
  naturalPerson=false, address.taxId, companyName/address.company.name).
  Wczesniej tylko invoice.required -> analogiczna luka jak shopPRO.
- Migracja 20260513_000113: idempotentny backfill (UPDATE invoice_requested=1
  WHERE is_invoice=1 AND invoice_requested=0) + DROP COLUMN orders.is_invoice.
  Guard przez information_schema.COLUMNS + PREPARE/EXECUTE z ALTER TABLE COMMENT
  no-op fallbackiem (portable MySQL/MariaDB).
- Cleanup is_invoice z OrderImportRepository (INSERT cols/values/params,
  docstring Phase 112) i OrdersRepository (paginate SELECT, transformOrderRow
  hydrate). AllegroOrderImportService mapping w mapCheckoutFormPayload tez
  usuniety (wymuszone konsekwencja DROP COLUMN).
- Bugfix #1089: zamowienie shopPRO z firm_nip (bez wants_invoice/invoice.required)
  ustawia teraz invoice_requested=1 -> UI w zakladce Platnosci zaznacza checkbox,
  przycisk "Wystaw fakture" widoczny.

Pending operator: php bin/migrate.php (XAMPP MySQL online) -> backfill 7 zamowien.
Smoke test: re-import shopPRO + nowe Allegro z NIP.

2026-05-12 22:11:49 +02:00

5.2 KiB

Raw Blame History

Project State

Project Reference

See: .paul/PROJECT.md (updated 2026-05-07)

Core value: Sprzedawca moze obslugiwac zamowienia ze wszystkich kanalow sprzedazy i nadawac przesylki bez przelaczania sie miedzy platformami. Current focus: v3.7 Invoices + operational integrations - Phase 125 invoice_requested import fix complete (UNIFY closed).

Current Position

Milestone: v3.7 Invoices (Fakturownia integration) - In progress Phase: 125 of TBD (invoice_requested import fix) - Complete Plan: 125-01 complete Status: UNIFY complete, transition pending (commit + ROADMAP update) Last activity: 2026-05-13 - UNIFY closed for .paul/phases/125-invoice-requested-import-fix/125-01-PLAN.md

Progress:

Milestone v3.7: [##########] ~99% (Phase 113-125 complete; transition pending)
Phase 125: [##########] 100%

Loop Position

Current loop state:

PLAN -> APPLY -> UNIFY
  done      done       done   [Loop complete - transition pending]

Session Continuity

Last session: 2026-05-13 Stopped at: Phase 125-01 UNIFY closed; SUMMARY.md created Next action: Phase transition (commit + ROADMAP update), then pick next v3.7 candidate or transition to v3.8 Resume file: .paul/ROADMAP.md

Pending parallel work

None — Phase 118, 121, 122 wszystkie zacommitowane (8f14851, 360eef1).

Git State

Last phase commit: 522c94a feat(124): sms templates CRUD + order picker Previous: 360eef1 feat(121+122): smsplanet conversation, notifications, default footer Branch: main Note: routes/web.php, DOCS/* i .paul/codebase/* zawierały zmiany z 118+121+122 nakładkowo i wszystkie wpadły do commitu 360eef1.

Pending Actions

Manualne testy AC-1..AC-7 dla Phase 112 na zywej bazie (XAMPP online).
Backfill zamowienia #882 - operator robi recznie po wdrozeniu (poza zakresem planu).
Uruchom migracje gdy XAMPP online: php bin/migrate.php (delivery_statuses).
Recznie odtworzyc istniejace reguly automatyzacji z grupowymi kluczami (BREAKING z 108-02).
HostedSMS inbound replies: requires DCS/HostedSMS activation before implementation.
Phase 117 follow-up: run migration when XAMPP MySQL is online and manually test real SMSPLANET sends for Bearer token and key + password.
Phase 119 follow-up: composer install + vendor/bin/phpunit tests/Unit/OrderImportRepositoryTest.php to run the 3 new tests; manual smoke test re-syncing order #976 from shoppro to confirm total_paid=91.00 persists across re-import.
Phase 121 follow-up: manually verify SMSPLANET settings/test send, inbound webhook insertion, order SMS tab, and notification polling/browser notification.
Phase 121 transition note: git commit was not created during UNIFY because the worktree contains unrelated Phase 118/local dirty files; prepare a scoped commit manually.
Phase 122 follow-up: manually verify settings save/reload and real SMSPLANET test/order sends with non-empty and empty footer; manually trigger over-limit final body rejection in UI.
Phase 123 follow-up: wystaw nowy paragon i potwierdz items_json zawiera vat per pozycja; eksport XLSX z paragonem multi-rate (np. mix 23% + 8%) — sprawdz osobne wiersze; eksport "wybrane paragony" zachowuje breakdown.
Phase 123 deferred: RECEIPT-NET-FIX (ReceiptService::issue() zapisuje total_net=total_gross) — udokumentowane w .paul/codebase/todo.md.
Phase 124 follow-up: php bin/migrate.php (XAMPP MySQL online) — utworzy sms_templates. Operator nastepnie tworzy szablony manualnie z /settings/sms-templates.
Phase 124 follow-up: real smoke wysylki SMS z szablonu (zamowienie z paczka + skonfigurowana stopka SMSPLANET) — sprawdzic ze sms_messages.body ma stopke raz, finalna tresc <= 918 znakow.
Phase 124 follow-up: regresja Email — wyslij e-mail z istniejacym szablonem aby potwierdzic ze refaktor Email\VariableResolver na fasade nie zlamal EmailSendingService.
Phase 125 follow-up: uruchom php bin/migrate.php (XAMPP MySQL online) — backfill 7 zamowien + DROP COLUMN orders.is_invoice. Weryfikacja: SELECT id, invoice_requested FROM orders WHERE id=1089; -> 1; SHOW COLUMNS FROM orders LIKE 'is_invoice'; -> empty.
Phase 125 follow-up: ponowne uruchomienie migracji powinno byc no-op (ALTER TABLE orders COMMENT = 'phase-125 backfill no-op').
Phase 125 follow-up: zaimportuj nowe zamowienie shopPRO z firm_nip (bez kluczy w 5-elementowej liscie wczesniejszej heurystyki) -> potwierdz ze UI w zakladce Platnosci pokazuje zaznaczony checkbox „Klient prosi o fakture" i widoczny przycisk „Wystaw fakture".
Phase 121 transition note (rozwiązane): commit 360eef1 obejmuje Phase 121 i Phase 122 razem; per-faza hunk-split nie wykonany ze względu na nakładkowe modyfikacje plików.

Deferred to Next Milestones

Phase 68 - Code Deduplication Refactor (0/2 Planning, nigdy nie rozpoczety).
STAT-NET - netto shopPRO z API lub z order_items.tax_rate (.paul/TODO.md).
Mobile Orders List / Mobile Order Details / Mobile Settings.
INDEX-106-01 - indeksy DB dla query customer_returned_count: order_addresses(order_id, address_type), shipment_packages(order_id, delivery_status) (gdy dataset >50k wierszy).

Skill Requirements

sonar-scanner required after APPLY; Phase 116, Phase 117, Phase 121 and Phase 122 gaps documented because CLI was not available in PATH.

5.2 KiB Raw Blame History