Jacek Pyziak
aadf98bc80
Added EXISTS subquery on order_items.original_name to the search filter in OrdersRepository::buildPaginateFilters(). Users can now find orders by typing a product name in the search field. Updated search placeholder to reflect the new capability. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
100 lines
2.7 KiB
Markdown
100 lines
2.7 KiB
Markdown
---
|
|
phase: 73-search-by-product
|
|
plan: 01
|
|
subsystem: api
|
|
tags: [search, orders, order_items, EXISTS]
|
|
|
|
requires: []
|
|
provides:
|
|
- Wyszukiwanie zamowien po nazwie produktu
|
|
affects: []
|
|
|
|
tech-stack:
|
|
added: []
|
|
patterns: [EXISTS subquery for search without JOIN duplicates]
|
|
|
|
key-files:
|
|
created: []
|
|
modified: [src/Modules/Orders/OrdersRepository.php, resources/lang/pl.php]
|
|
|
|
key-decisions:
|
|
- "EXISTS subquery zamiast JOIN — brak duplikatow, brak zmian w countSql/buildListSql"
|
|
- "Rozszerzenie istniejacego pola szukaj zamiast osobnego pola produktowego"
|
|
|
|
patterns-established: []
|
|
|
|
duration: 5min
|
|
started: 2026-04-07T12:30:00Z
|
|
completed: 2026-04-07T12:35:00Z
|
|
---
|
|
|
|
# Phase 73 Plan 01: Search by Product Summary
|
|
|
|
**Rozszerzenie wyszukiwarki zamowien o nazwe produktu — EXISTS subquery na order_items.original_name.**
|
|
|
|
## Performance
|
|
|
|
| Metric | Value |
|
|
|--------|-------|
|
|
| Duration | ~5min |
|
|
| Tasks | 2 completed |
|
|
| Files modified | 2 |
|
|
|
|
## Acceptance Criteria Results
|
|
|
|
| Criterion | Status | Notes |
|
|
|-----------|--------|-------|
|
|
| AC-1: Wyszukiwanie po nazwie produktu | Pass | "Tabliczki" → 10 zamowien |
|
|
| AC-2: Istniejace wyszukiwanie bez zmian | Pass | "11776" → 1 zamowienie |
|
|
| AC-3: Brak duplikatow wynikow | Pass | EXISTS gwarantuje 0 duplikatow |
|
|
| AC-4: Placeholder zaktualizowany | Pass | "Szukaj (numer, klient, email, produkt)" |
|
|
|
|
## Accomplishments
|
|
|
|
- Dodano EXISTS subquery `order_items oi_s` do warunku search w buildPaginateFilters
|
|
- Zaktualizowano placeholder w tlumaczeniach pl.php
|
|
- Zweryfikowano na zdalnej bazie: brak regresji, brak duplikatow
|
|
|
|
## Files Created/Modified
|
|
|
|
| File | Change | Purpose |
|
|
|------|--------|---------|
|
|
| `src/Modules/Orders/OrdersRepository.php` | Modified | EXISTS subquery + parametr :s6 w search |
|
|
| `resources/lang/pl.php` | Modified | Placeholder "produkt" w filtrze search |
|
|
|
|
## Decisions Made
|
|
|
|
| Decision | Rationale | Impact |
|
|
|----------|-----------|--------|
|
|
| EXISTS zamiast JOIN | Brak duplikatow, brak zmian w countSql/buildListSql | Czystsza implementacja |
|
|
| Alias oi_s dla subquery | Unikniecie konfliktu z istniejacym oi_agg w buildListSql | Brak ryzyka kolizji nazw |
|
|
|
|
## Deviations from Plan
|
|
|
|
### Summary
|
|
|
|
| Type | Count | Impact |
|
|
|------|-------|--------|
|
|
| Scope additions | 1 | Minimalny — plik tlumaczen zamiast widoku |
|
|
|
|
Placeholder byl w `resources/lang/pl.php` a nie w `resources/views/orders/list.php` jak zakladal plan. Zmiana w odpowiednim pliku.
|
|
|
|
## Issues Encountered
|
|
|
|
None
|
|
|
|
## Next Phase Readiness
|
|
|
|
**Ready:**
|
|
- Wyszukiwanie po produkcie dziala na wszystkich listach zamowien
|
|
|
|
**Concerns:**
|
|
- Przy bardzo duzej liczbie zamowien EXISTS moze byc wolniejszy niz indeks FULLTEXT — obecnie skala jest OK
|
|
|
|
**Blockers:**
|
|
- None
|
|
|
|
---
|
|
*Phase: 73-search-by-product, Plan: 01*
|
|
*Completed: 2026-04-07*
|